This repository was archived by the owner on Feb 20, 2026. It is now read-only.
security: replace vulnerable parse-duration with CJS compatible ms library#960
Merged
aabmass merged 2 commits intogoogleapis:mainfrom Apr 9, 2025
Merged
security: replace vulnerable parse-duration with CJS compatible ms library#960aabmass merged 2 commits intogoogleapis:mainfrom
aabmass merged 2 commits intogoogleapis:mainfrom
Conversation
product-auto-label
Bot
added
size: m
aabmass
commented
Apr 9, 2025
| return undefined; | ||
| } | ||
|
|
||
| /** |
Contributor
Author
There was a problem hiding this comment.
This is dead code which was missed in #402
aabmass
force-pushed
the
parseduration-to-ms
branch
2 times, most recently
from
a0c7f7a to
f28722c
Compare
aabmass
commented
Apr 9, 2025
aabmass
force-pushed
the
parseduration-to-ms
branch
from
f28722c to
8ac9384
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #960 +/- ##
==========================================
+ Coverage 69.50% 70.15% +0.64%
==========================================
Files 7 7
Lines 1256 1243 -13
Branches 48 49 +1
==========================================
- Hits 873 872 -1
+ Misses 382 370 -12
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
punya
reviewed
Apr 9, 2025
| } | ||
| ); | ||
| }); | ||
| describe('parseBackoffDuration', () => { |
Contributor
There was a problem hiding this comment.
Why are these tests no longer necessary?
Contributor
Author
There was a problem hiding this comment.
I removed the tested function which was dead code missed in #402
psx95
reviewed
Apr 9, 2025
psx95
approved these changes
Apr 9, 2025
Contributor
Author
|
I'm not sure why codecov is complaining since there are tests covering this code which break if I introduce a bug. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #953
Replace parse-duration with ms, which provides ESM and CJS builds.
BEGIN_COMMIT_OVERRIDE
fix: replace vulnerable parse-duration with CJS compatible ms library
END_COMMIT_OVERRIDE