This repository was archived by the owner on Feb 20, 2026. It is now read-only.
chore: Remove hack for determining server-specified backoff.#402
Merged
kalyanac merged 8 commits intogoogleapis:masterfrom Feb 25, 2019
Merged
chore: Remove hack for determining server-specified backoff.#402kalyanac merged 8 commits intogoogleapis:masterfrom
kalyanac merged 8 commits intogoogleapis:masterfrom
Conversation
googlebot
added
the
cla: yes
Contributor
Author
|
@kinwa91 -- What's It fails with: |
Contributor
Author
|
Failing tests are unrelated to this change. |
Contributor
|
Can we fix the tests first? Reviewing PR with failing tests / checks just doesn't feel good or right. |
Contributor
|
@aalexand all that should be taken care of now :) |
Contributor
Author
|
PTAL |
aalexand
approved these changes
Feb 19, 2019
Contributor
|
@kalyanac @nolanmar511 Reviewed, Kalyana to also review and merge. |
Contributor
Author
|
@kalyanac -- any thoughts, or is this ready to be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #250
Tested: Ran ~20 node jobs with matching service/version/labels. Confirmed that back off matched the back offs specified in the response body.