Skip to content

fix(generator): fall back to java.lang.Object for unknown types. #31517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
diegomarquezp wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −6
Open

fix(generator): fall back to java.lang.Object for unknown types. #31517

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions generator/src/googleapis/codegen/java_generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,12 +261,10 @@ def _GetTypeInfo(self, def_dict):
if result:
return result

# TODO(user): Uncomment this and update golden files.
# result = self.type_map.get((json_type, None))
# if result:
# return result
#
# raise ValueError('Unknown type: %s format: %s' % (json_type, json_format))
# Fallback to the unformatted base type if exact format mapping is not found.
Copy link
Copy Markdown
Contributor

@blakeli0 blakeli0 Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that the generated code changed from

  private java.util.Map<String, Any> entries;

to

  private java.util.Map<String, java.lang.Object> entries;

Is it possible to test it in a real client?

result = self.type_map.get((json_type, None))
if result:
return result

return (utilities.CamelCase(json_type), None, None)

Expand Down