Skip to content

fix: rollback generator - #4004

Merged
danieljbruce merged 8 commits into
mainfrom
rollback-generator-and-testing-2
Sep 4, 2026
Merged

fix: rollback generator#4004
danieljbruce merged 8 commits into
mainfrom
rollback-generator-and-testing-2

Conversation

@danieljbruce

Copy link
Copy Markdown
Contributor

Description

#3992 is being rolled back because these changes must be re-merged with a feat! commit message so that all libraries get a major version upgrade in the release PR so that users upgrading to Node v22 must intentionally opt-in to avoid breaking changes.

Impact

Fix the release to rollout major versions for Node 22.

Additional notes

We are going to revert these changes in a subsequent PR.

@product-auto-label product-auto-label Bot added the size: xl Pull request size is extra large. label Sep 4, 2026
@danieljbruce danieljbruce added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 4, 2026
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 4, 2026
We need the owlbot postprocessor to pass
@danieljbruce danieljbruce added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Sep 4, 2026
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 4, 2026
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 4, 2026
@danieljbruce danieljbruce added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 4, 2026
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 4, 2026
@danieljbruce
danieljbruce marked this pull request as ready for review September 4, 2026 18:07
@danieljbruce
danieljbruce requested a review from a team as a code owner September 4, 2026 18:07
@danieljbruce
danieljbruce enabled auto-merge (rebase) September 4, 2026 18:41

@bshaffer bshaffer left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you put this in the PR description of the already merged PR and then you regenerate the release please PR, it should update the conventional commit:

BEGIN_COMMIT_OVERRIDE
feat!: foo bar baz
END_COMMIT_OVERRIDE

We should try that first before rolling things back, if the only goal is to change the conventional commit

@danieljbruce

danieljbruce commented Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

If you put this in the PR description of the already merged PR and then you regenerate the release please PR, it should update the conventional commit:

BEGIN_COMMIT_OVERRIDE
feat!: foo bar baz
END_COMMIT_OVERRIDE

We should try that first before rolling things back, if the only goal is to change the conventional commit

I found this doesn't work because this was actually merged in a commit sent out in the last release. This pull request rolls back the breaking changes (the node engine upgrade) so we should merge these changes and then cut another minor release.

@bshaffer bshaffer left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I didn't understand that the releases had already gone out. I agree that reverting them, cutting a new release with the reverted changes, and then marking the previous release as deprecated is the best policy here

@danieljbruce
danieljbruce merged commit 41a90eb into main Sep 4, 2026
28 checks passed
@danieljbruce
danieljbruce deleted the rollback-generator-and-testing-2 branch September 4, 2026 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: xl Pull request size is extra large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants