Force SSL negociation to use last TLS#360
Merged
Merged
Conversation
Contributor
|
Thanks! Is 1 == CURL_SSLVERSION_TLSv1_0 ? I know that constant isn't in older versions of PHP, but I presume that cURL will handle it anyway. Might be worth a comment to indicate that though. Can you sign the CLA, then I shall merge this. https://github.com/google/google-api-php-client/blob/master/CONTRIBUTING.md |
ianbarber
added
the
cla: no
Author
|
Cheers for the heads up! I have submitted my CLA. |
ianbarber
added
type: feature request
Contributor
|
Thanks! |
ianbarber
added a commit
that referenced
this pull request
Oct 22, 2014
Force SSL negociation to use last TLS
ianbarber
pushed a commit
to ianbarber/google-api-php-client
that referenced
this pull request
Nov 7, 2014
ianbarber
added a commit
that referenced
this pull request
Nov 7, 2014
Add descriptive comment for #360
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since yesterday, calling the API generates loads of "SSL routines:SSL3_GET_RECORD:wrong version number" as well as "SSL routines:SSL3_GET_RECORD:decryption failed or bad record mac".
We figured it could be coming from Google deprecating SSL v3.
Using CURLOPT_SSLVERSION to set the remote SSL protocol version to TLSv1 worked for us.