Skip to content

ci: otel_collector updates - #16284

Merged
scotthart merged 2 commits into
googleapis:mainfrom
scotthart:ci_otel_collector_updates
Jul 29, 2026
Merged

ci: otel_collector updates#16284
scotthart merged 2 commits into
googleapis:mainfrom
scotthart:ci_otel_collector_updates

Conversation

@scotthart

Copy link
Copy Markdown
Member

Tidying up some things ahead of a bigger PR.

@scotthart
scotthart requested a review from a team as a code owner July 28, 2026 17:20

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the otel_collector tool to use inline namespaces and include the version header, aligning it with the SDK's namespace standards. It also updates the Bazel and CMake build configurations to add the common library dependency and clean up target definitions. The review feedback points out a redundant add_dependencies call in CMakeLists.txt that can be safely removed because the dependency is already established via target_link_libraries.

Comment thread ci/otel_collector/CMakeLists.txt Outdated
@codecov

codecov Bot commented Jul 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.30%. Comparing base (f07c472) to head (a9bd631).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #16284   +/-   ##
=======================================
  Coverage   92.30%   92.30%           
=======================================
  Files        2223     2223           
  Lines      207876   207876           
=======================================
+ Hits       191880   191881    +1     
+ Misses      15996    15995    -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@scotthart
scotthart merged commit fdcd3a9 into googleapis:main Jul 29, 2026
67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants