chore(storage): reduce deprecation warnings from tests - #16405
Conversation
product-auto-label
Bot
added
the
api: storage
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds file-wide deprecation warning suppressions to several test files in the Google Cloud Storage internal library. The reviewer recommends keeping the deprecation warning suppression localized in object_requests_test.cc rather than applying it file-wide, to avoid masking accidental uses of deprecated APIs in other tests.
| // TODO(#16404): Remove deprecation disable include. | ||
| #include "google/cloud/internal/disable_deprecation_warnings.inc" |
There was a problem hiding this comment.
Disabling deprecation warnings for the entire file can mask accidental uses of deprecated APIs in other tests within this file. Since the suppression was previously localized specifically to the InsertObjectBackwardsCompat test, it is highly recommended to keep it localized there using disable_deprecation_warnings.inc and diagnostics_pop.inc to maintain warning coverage for the rest of the file.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16405 +/- ##
==========================================
+ Coverage 92.24% 92.26% +0.01%
==========================================
Files 2246 2246
Lines 212136 212136
==========================================
+ Hits 195692 195732 +40
+ Misses 16444 16404 -40 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
2 participants
Part of the work for #16404