Run integration tests in Ubuntu 14.04#370
Merged
coryan merged 4 commits intogoogleapis:masterfrom Mar 24, 2018
Merged
Conversation
The tests were disabled because we used to build the Cloud Bigtable Emulator from source, and Ubuntu 14.04 native golang tools could not do it. Now that we install the emulator via the Cloud SDK, this is no longer an issue. This fixes googleapis#361.
coryan
requested review from
deepankarsharma,
ghaisa,
mbrukman,
richjames0 and
sduskis
googlebot
added
the
cla: yes
roopak-qlogic
pushed a commit
to roopak-qlogic/google-cloud-cpp
that referenced
this pull request
Apr 1, 2018
The tests were disabled because we used to build the Cloud Bigtable Emulator from source, and Ubuntu 14.04 native golang tools could not do it. Now that we install the emulator via the Cloud SDK, this is no longer an issue. This fixes googleapis#361. Ignore testing components in code coverage reports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable the integration tests in Ubuntu 14.04. They were previously disabled because
we could not compile the Cloud Bigtable Emulator from source on this platform, but
now we install the pre-compiled binaries.
Also cleaned up the code coverage to ignore test support code and tests. That is a
more realistic measure of how good is the code that application developers will
actually use. The new numbers are visible here:
https://codecov.io/gh/coryan/google-cloud-cpp/tree/run-integration-tests-in-ubuntu-14.04/bigtable/client