Skip to content

test(bigquery): Fix flaky ITBigQueryTest#testOpenTelemetryTracingQuery#12769

Merged
jinseopkim0 merged 5 commits intomainfrom
flaky-3
Apr 14, 2026
Merged

test(bigquery): Fix flaky ITBigQueryTest#testOpenTelemetryTracingQuery#12769
jinseopkim0 merged 5 commits intomainfrom
flaky-3

Conversation

@jinseopkim0
Copy link
Copy Markdown
Contributor

b/467063732

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the testOpenTelemetryTracingQuery integration test to handle cases where BigQuery creates a job despite the JOB_CREATION_OPTIONAL setting. The review feedback correctly identifies that the original assertion for a null job ID was lost for the standard case and suggests adding an else block to maintain that validation.

jinseopkim0 and others added 2 commits April 13, 2026 13:36
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@jinseopkim0 jinseopkim0 marked this pull request as ready for review April 13, 2026 20:00
@jinseopkim0 jinseopkim0 requested review from a team as code owners April 13, 2026 20:00
@jinseopkim0 jinseopkim0 requested a review from lqiu96 April 13, 2026 20:00
@jinseopkim0 jinseopkim0 enabled auto-merge (squash) April 13, 2026 20:01
@jinseopkim0 jinseopkim0 merged commit 7f2ad61 into main Apr 14, 2026
112 of 113 checks passed
@jinseopkim0 jinseopkim0 deleted the flaky-3 branch April 14, 2026 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants