Skip to content

test(bigquery): Fix flaky ITBigQueryTest#testOpenTelemetryTracingQuery #12769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jinseopkim0 merged 5 commits into from
Apr 14, 2026
+11 −1
Merged

test(bigquery): Fix flaky ITBigQueryTest#testOpenTelemetryTracingQuery #12769

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
63aa302
test(bigquery): Fix flaky ITBigQueryTest#testOpenTelemetryTracingQuery
jinseopkim0 Apr 13, 2026
89b729d
Apply suggestion from @gemini-code-assist[bot]
jinseopkim0 Apr 13, 2026
5035469
Merge branch 'main' into flaky-3
jinseopkim0 Apr 13, 2026
b662fee
PR feedback
jinseopkim0 Apr 14, 2026
b25b6a0
Merge branch 'main' into flaky-3
jinseopkim0 Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion ...uery/google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/it/ITBigQueryTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7889,7 +7889,17 @@ public void testOpenTelemetryTracingQuery() throws InterruptedException {
bigquery.getOptions().setDefaultJobCreationMode(JobCreationMode.JOB_CREATION_OPTIONAL);
TableResult tableResult = executeSimpleQuery(bigquery);
assertNotNull(tableResult.getQueryId());
assertNull(tableResult.getJobId());

// Safely handle the fallback where BigQuery determines a job must be created
// even if the mode is optional. Most requests will be stateless, but it is still
// possible that the BQ engine will create a job even for tiny requests.
if (tableResult.getJobCreationReason() != null) {
assertNotNull(tableResult.getJobId());
assertEquals(tableResult.getQueryId(), tableResult.getJobId().getJob());
assertEquals(JobCreationReason.Code.OTHER, tableResult.getJobCreationReason().getCode());
} else {
assertNull(tableResult.getJobId());
}

assertNotNull(OTEL_ATTRIBUTES.get("com.google.cloud.bigquery.BigQuery.queryRpc"));
assertNotNull(
Expand Down
Loading