Skip to content

ci: bring the dependencies check back#12906

Merged
suztomo merged 17 commits intogoogleapis:mainfrom
suztomo:bring-back-dependencies-check
Apr 24, 2026
Merged

ci: bring the dependencies check back#12906
suztomo merged 17 commits intogoogleapis:mainfrom
suztomo:bring-back-dependencies-check

Conversation

@suztomo
Copy link
Copy Markdown
Member

@suztomo suztomo commented Apr 23, 2026

This change adds the dependencies check back to the ci.yaml, google-auth-library-java-ci.yaml, and sdk-platform-java-ci.yaml.

This pull request removes unnecessary java version matrix logic in existing dependencies check. Java 17 just works fine.

This pull request removes the retry logic in dependencies.sh because at the time this Maven command runs Maven's dependency resolution, which may hit transient errors for network connection, is already done.

ignoreNonCompile property is maven-dependency-plugin's property to skip non-compile dependencies. https://maven.apache.org/plugins/maven-dependency-plugin/analyze-only-mojo.html#ignorenoncompile

Ignore runtime/provided/test/system scopes for unused dependency analysis.

This is useful to skip test scope dependencies because they do not go to library users' class path.

Fixes #12895

b/505481903

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@suztomo
Copy link
Copy Markdown
Member Author

suztomo commented Apr 23, 2026

It detected bad dependency tree.

Error:  Failed to execute goal org.apache.maven.plugins:maven-enforcer-plugin:3.5.0:enforce (enforce) on project google-auth-library-cab-token-generator: 
Error:  Rule 2: org.apache.maven.enforcer.rules.dependency.RequireUpperBoundDeps failed with message:
Error:  Failed while enforcing RequireUpperBoundDeps. The error(s) are [
Error:  Require upper bound dependencies error for com.google.j2objc:j2objc-annotations:3.0.0 paths to dependency are:
Error:  +-com.google.auth:google-auth-library-cab-token-generator:1.46.0
Error:    +-com.google.http-client:google-http-client:2.1.0
Error:      +-com.google.j2objc:j2objc-annotations:3.0.0
Error:  and
Error:  +-com.google.auth:google-auth-library-cab-token-generator:1.46.0
Error:    +-com.google.guava:guava:33.5.0-android
Error:      +-com.google.j2objc:j2objc-annotations:3.1
Error:  and
Error:  +-com.google.auth:google-auth-library-cab-token-generator:1.46.0
Error:    +-com.google.auth:google-auth-library-oauth2-http:1.46.0
Error:      +-com.google.api:api-common:2.53.0 (managed) <-- com.google.api:api-common:2.53.0
Error:        +-com.google.j2objc:j2objc-annotations:3.0.0
Error:  ]
Error:  Rule 3: org.codehaus.mojo.extraenforcer.dependencies.BanDuplicateClasses failed with message:
Error:  Duplicate classes found:
Error:  
Error:    Found in:
Error:      com.google.code.findbugs:jsr305:jar:3.0.2:compile
Error:      com.google.code.findbugs:annotations:jar:3.0.1:compile
Error:    Duplicate classes:
Error:      javax/annotation/RegEx$Checker.class
Error:      javax/annotation/MatchesPattern$Checker.class
Error:      javax/annotation/meta/When.class
Error:      javax/annotation/Nonnull$Checker.class
Error:      javax/annotation/Nonnegative$Checker.class

@suztomo
Copy link
Copy Markdown
Member Author

suztomo commented Apr 23, 2026

Dependency graph of the cab-token module

[INFO] --- dependency:3.8.1:tree (default-cli) @ google-auth-library-cab-token-generator ---
[INFO] com.google.auth:google-auth-library-cab-token-generator:jar:1.46.0
[INFO] +- com.google.guava:guava:jar:33.5.0-android:compile
[INFO] |  +- com.google.guava:failureaccess:jar:1.0.3:compile
[INFO] |  +- com.google.guava:listenablefuture:jar:9999.0-empty-to-avoid-conflict-with-guava:compile
[INFO] |  +- org.jspecify:jspecify:jar:1.0.0:compile
[INFO] |  +- (com.google.errorprone:error_prone_annotations:jar:2.42.0:compile - version managed from 2.41.0; omitted for duplicate)
[INFO] |  \- com.google.j2objc:j2objc-annotations:jar:3.1:compile
[INFO] +- com.google.auth:google-auth-library-oauth2-http:jar:1.46.0:compile
[INFO] |  +- (com.google.guava:guava:jar:33.5.0-android:compile - version managed from 33.5.0-android; omitted for duplicate)
[INFO] |  +- com.google.auto.value:auto-value-annotations:jar:1.11.0:compile (version managed from 1.11.0)
[INFO] |  +- com.google.code.findbugs:jsr305:jar:3.0.2:compile (version managed from 3.0.2)
[INFO] |  +- (com.google.auth:google-auth-library-credentials:jar:1.46.0:compile - version managed from 1.46.0; omitted for duplicate)
[INFO] |  +- (com.google.http-client:google-http-client:jar:2.1.0:compile - version managed from 2.1.0; omitted for duplicate)
[INFO] |  +- (com.google.http-client:google-http-client-gson:jar:2.1.0:compile - version managed from 2.1.0; omitted for duplicate)
[INFO] |  +- (com.google.errorprone:error_prone_annotations:jar:2.42.0:compile - version managed from 2.42.0; omitted for duplicate)
[INFO] |  +- com.google.api:api-common:jar:2.53.0:compile (version managed from 2.53.0)
[INFO] |  |  +- (com.google.guava:guava:jar:33.5.0-android:compile - version managed from 33.4.0-jre; omitted for duplicate)
[INFO] |  |  +- (com.google.auto.value:auto-value-annotations:jar:1.11.0:compile - version managed from 1.11.0; omitted for duplicate)
[INFO] |  |  +- (com.google.code.findbugs:jsr305:jar:3.0.2:compile - version managed from 3.0.2; omitted for duplicate)
[INFO] |  |  +- javax.annotation:javax.annotation-api:jar:1.3.2:compile
[INFO] |  |  +- (com.google.errorprone:error_prone_annotations:jar:2.42.0:compile - version managed from 2.38.0; omitted for duplicate)
[INFO] |  |  \- (com.google.j2objc:j2objc-annotations:jar:3.0.0:compile - omitted for conflict with 3.1)
[INFO] |  \- com.google.code.gson:gson:jar:2.12.1:compile
[INFO] |     \- (com.google.errorprone:error_prone_annotations:jar:2.42.0:compile - version managed from 2.36.0; omitted for duplicate)
[INFO] +- com.google.auth:google-auth-library-credentials:jar:1.46.0:compile
[INFO] +- com.google.http-client:google-http-client:jar:2.1.0:compile
[INFO] |  +- org.apache.httpcomponents:httpclient:jar:4.5.14:compile
[INFO] |  |  +- (org.apache.httpcomponents:httpcore:jar:4.4.16:compile - omitted for duplicate)
[INFO] |  |  \- commons-codec:commons-codec:jar:1.11:compile
[INFO] |  +- org.apache.httpcomponents:httpcore:jar:4.4.16:compile
[INFO] |  +- (com.google.code.findbugs:jsr305:jar:3.0.2:compile - version managed from 3.0.2; omitted for duplicate)
[INFO] |  +- (com.google.errorprone:error_prone_annotations:jar:2.42.0:compile - version managed from 2.36.0; omitted for duplicate)
[INFO] |  +- (com.google.guava:guava:jar:33.5.0-android:compile - version managed from 33.4.8-android; omitted for duplicate)
[INFO] |  +- (com.google.j2objc:j2objc-annotations:jar:3.0.0:compile - omitted for conflict with 3.1)
[INFO] |  +- io.grpc:grpc-context:jar:1.70.0:compile
[INFO] |  |  \- io.grpc:grpc-api:jar:1.70.0:runtime
[INFO] |  +- io.opencensus:opencensus-api:jar:0.31.1:compile
[INFO] |  |  \- (io.grpc:grpc-context:jar:1.27.2:compile - omitted for conflict with 1.70.0)
[INFO] |  \- io.opencensus:opencensus-contrib-http-util:jar:0.31.1:compile
[INFO] |     +- (io.opencensus:opencensus-api:jar:0.31.1:compile - omitted for duplicate)
[INFO] |     \- (com.google.guava:guava:jar:33.5.0-android:compile - version managed from 29.0-android; omitted for duplicate)
[INFO] +- com.google.errorprone:error_prone_annotations:jar:2.42.0:compile
[INFO] +- com.google.protobuf:protobuf-java:jar:4.33.2:compile
[INFO] +- dev.cel:cel:jar:0.9.0-proto3:compile
[INFO] |  +- (com.google.auto.value:auto-value-annotations:jar:1.11.0:compile - version managed from 1.11.0; omitted for duplicate)
[INFO] |  +- com.google.code.findbugs:annotations:jar:3.0.1:compile
[INFO] |  |  +- net.jcip:jcip-annotations:jar:1.0:compile
[INFO] |  |  \- (com.google.code.findbugs:jsr305:jar:3.0.2:compile - version managed from 3.0.1; omitted for duplicate)
[INFO] |  +- (com.google.errorprone:error_prone_annotations:jar:2.42.0:compile - version managed from 2.36.0; omitted for duplicate)
[INFO] |  +- (com.google.guava:guava:jar:33.5.0-android:compile - version managed from 33.3.1-jre; omitted for duplicate)
[INFO] |  +- (com.google.protobuf:protobuf-java:jar:4.33.2:compile - version managed from 3.25.5; omitted for duplicate)
[INFO] |  +- com.google.protobuf:protobuf-java-util:jar:4.33.2:compile (version managed from 3.25.5)
[INFO] |  |  +- (com.google.protobuf:protobuf-java:jar:4.33.2:compile - version managed from 4.33.2; omitted for duplicate)
[INFO] |  |  +- (com.google.code.findbugs:jsr305:jar:3.0.2:runtime - version managed from 3.0.2; omitted for duplicate)
[INFO] |  |  +- (com.google.code.gson:gson:jar:2.8.9:runtime - omitted for conflict with 2.12.1)
[INFO] |  |  \- (com.google.errorprone:error_prone_annotations:jar:2.42.0:runtime - version managed from 2.18.0; omitted for duplicate)
[INFO] |  +- com.google.re2j:re2j:jar:1.7:compile
[INFO] |  +- org.antlr:antlr4-runtime:jar:4.13.2:compile
[INFO] |  +- (org.jspecify:jspecify:jar:1.0.0:compile - omitted for duplicate)
[INFO] |  \- org.threeten:threeten-extra:jar:1.8.0:compile
[INFO] +- com.google.crypto.tink:tink:jar:1.15.0:compile
[INFO] |  +- (com.google.code.findbugs:jsr305:jar:3.0.2:compile - version managed from 3.0.2; omitted for duplicate)
[INFO] |  +- (com.google.code.gson:gson:jar:2.10.1:compile - omitted for conflict with 2.12.1)
[INFO] |  +- (com.google.errorprone:error_prone_annotations:jar:2.42.0:compile - version managed from 2.22.0; omitted for duplicate)
[INFO] |  \- (com.google.protobuf:protobuf-java:jar:4.33.2:compile - version managed from 3.25.3; omitted for duplicate)
[INFO] +- junit:junit:jar:4.13.2:test
[INFO] |  \- org.hamcrest:hamcrest-core:jar:1.3:test
[INFO] +- org.junit.jupiter:junit-jupiter-api:jar:5.11.4:test
[INFO] |  +- org.opentest4j:opentest4j:jar:1.3.0:test
[INFO] |  +- org.junit.platform:junit-platform-commons:jar:1.11.4:test (version managed from 1.11.4)
[INFO] |  |  \- (org.apiguardian:apiguardian-api:jar:1.1.2:test - omitted for duplicate)
[INFO] |  \- org.apiguardian:apiguardian-api:jar:1.1.2:test
[INFO] +- org.junit.jupiter:junit-jupiter-engine:jar:5.11.4:test
[INFO] |  +- org.junit.platform:junit-platform-engine:jar:1.11.4:test (version managed from 1.11.4)
[INFO] |  |  +- (org.opentest4j:opentest4j:jar:1.3.0:test - omitted for duplicate)
[INFO] |  |  +- (org.junit.platform:junit-platform-commons:jar:1.11.4:test - version managed from 1.11.4; omitted for duplicate)
[INFO] |  |  \- (org.apiguardian:apiguardian-api:jar:1.1.2:test - omitted for duplicate)
[INFO] |  +- (org.junit.jupiter:junit-jupiter-api:jar:5.11.4:test - version managed from 5.11.4; omitted for duplicate)
[INFO] |  \- (org.apiguardian:apiguardian-api:jar:1.1.2:test - omitted for duplicate)
[INFO] +- com.google.auth:google-auth-library-oauth2-http:test-jar:testlib:1.46.0:test
[INFO] |  +- (com.google.guava:guava:jar:33.5.0-android:test - version managed from 33.5.0-android; omitted for duplicate)
[INFO] |  +- (com.google.auto.value:auto-value-annotations:jar:1.11.0:test - version managed from 1.11.0; omitted for duplicate)
[INFO] |  +- (com.google.code.findbugs:jsr305:jar:3.0.2:test - version managed from 3.0.2; omitted for duplicate)
[INFO] |  +- (com.google.auth:google-auth-library-credentials:jar:1.46.0:test - version managed from 1.46.0; omitted for duplicate)
[INFO] |  +- (com.google.http-client:google-http-client:jar:2.1.0:test - version managed from 2.1.0; omitted for duplicate)
[INFO] |  +- (com.google.http-client:google-http-client-gson:jar:2.1.0:test - version managed from 2.1.0; omitted for duplicate)
[INFO] |  +- (com.google.errorprone:error_prone_annotations:jar:2.42.0:test - version managed from 2.42.0; omitted for duplicate)
[INFO] |  +- (com.google.api:api-common:jar:2.53.0:test - version managed from 2.53.0; omitted for duplicate)
[INFO] |  \- (com.google.code.gson:gson:jar:2.12.1:test - omitted for duplicate)
[INFO] +- org.mockito:mockito-core:jar:4.11.0:test
[INFO] |  +- net.bytebuddy:byte-buddy:jar:1.12.19:test
[INFO] |  +- net.bytebuddy:byte-buddy-agent:jar:1.12.19:test
[INFO] |  \- org.objenesis:objenesis:jar:3.3:test
[INFO] \- com.google.http-client:google-http-client-gson:jar:2.1.0:test (scope not updated to compile)
[INFO]    +- (com.google.http-client:google-http-client:jar:2.1.0:test - version managed from 2.1.0; omitted for duplicate)
[INFO]    \- (com.google.code.gson:gson:jar:2.11.0:test - omitted for conflict with 2.12.1)

@suztomo suztomo force-pushed the bring-back-dependencies-check branch from 52456a1 to b2434ca Compare April 23, 2026 23:56
@suztomo
Copy link
Copy Markdown
Member Author

suztomo commented Apr 24, 2026

[INFO] --- dependency:3.8.1:analyze (default-cli) @ api-common ---
Error:  Used undeclared dependencies found:
Error:     org.junit.jupiter:junit-jupiter-api:jar:5.11.4:test
Error:     junit:junit:jar:4.13.2:test
Error:  Unused declared dependencies found:
Error: [ERROR]    com.google.errorprone:error_prone_annotations:jar:2.45.0:compile
Error:     org.junit.jupiter:junit-jupiter-engine:jar:5.11.4:test
Error:     org.junit.vintage:junit-vintage-engine:jar:5.11.4:test
Error:     com.google.j2objc:j2objc-annotations:jar:3.1:compile

@suztomo suztomo force-pushed the bring-back-dependencies-check branch from d15dc2e to 6c3a3d6 Compare April 24, 2026 01:57
@suztomo
Copy link
Copy Markdown
Member Author

suztomo commented Apr 24, 2026

12:16:17:466 [ERROR] com.google.showcase.v1beta1.it.ITOtelTracing.testTracing_retry_httpjson -- Time elapsed: 0.009 s <<< FAILURE!
java.lang.AssertionError: unexpected exception type thrown; expected:<com.google.api.gax.rpc.InvalidArgumentException> but was:<com.google.api.gax.rpc.UnknownException>
	at org.junit.Assert.assertThrows(Assert.java:1020)
	at org.junit.Assert.assertThrows(Assert.java:981)
	at com.google.showcase.v1beta1.it.ITOtelTracing.testTracing_retry_httpjson(ITOtelTracing.java:492)
	at java.base/java.lang.reflect.Method.invoke([Method.java:566](https://cs.corp.google.com/#search/&sq=package:%5Epiper$%20project:openjdk25&q=java/lang/reflect/Method.java:566))
	at java.base/java.util.ArrayList.forEach([ArrayList.java:1541](https://cs.corp.google.com/#search/&sq=package:%5Epiper$%20project:openjdk25&q=java/util/ArrayList.java:1541))
	at java.base/java.util.ArrayList.forEach([ArrayList.java:1541](https://cs.corp.google.com/#search/&sq=package:%5Epiper$%20project:openjdk25&q=java/util/ArrayList.java:1541))
Caused by: com.google.api.gax.rpc.UnknownException: java.net.ConnectException: Connection refused (Connection refused)
	at com.google.api.gax.rpc.ApiExceptionFactory.createException(ApiExceptionFactory.java:129)
	at com.google.api.gax.rpc.ApiExceptionFactory.createException(ApiExceptionFactory.java:86)
	at com.google.api.gax.rpc.ApiExceptionFactory.createException(ApiExceptionFactory.java:41)
	at com.google.api.gax.httpjson.HttpJsonApiExceptionFactory.create(HttpJsonApiExceptionFactory.java:83)
	at com.google.api.gax.httpjson.HttpJsonExceptionCallable$ExceptionTransformingFuture.onFailure(HttpJsonExceptionCallable.java:97)
	at com.google.api.core.ApiFutures$1.onFailure(ApiFutures.java:84)
	at com.google.common.util.concurrent.Futures$CallbackListener.run(Futures.java:1125)
	at com.google.common.util.concurrent.DirectExecutor.execute(DirectExecutor.java:30)
	at com.google.common.util.concurrent.AbstractFuture.executeListener(AbstractFuture.java:1004)
	at com.google.common.util.concurrent.AbstractFuture.complete(AbstractFuture.java:767)
	at com.google.common.util.concurrent.AbstractFuture.setException(AbstractFuture.java:516)
	at com.google.api.core.AbstractApiFuture$InternalSettableFuture.setException(AbstractApiFuture.java:92)
	at com.google.api.core.AbstractApiFuture.setException(AbstractApiFuture.java:74)
	at com.google.api.gax.httpjson.HttpJsonClientCalls$HttpJsonFuture.setException(HttpJsonClientCalls.java:142)
	at com.google.api.gax.httpjson.HttpJsonClientCalls$FutureListener.onClose(HttpJsonClientCalls.java:176)
	at com.google.api.gax.httpjson.ForwardingHttpJsonClientCallListener.onClose(ForwardingHttpJsonClientCallListener.java:54)
	at com.google.api.gax.httpjson.HttpJsonLoggingInterceptor$1$1.onClose(HttpJsonLoggingInterceptor.java:95)
	at com.google.api.gax.httpjson.HttpJsonClientCallImpl$OnCloseNotificationTask.call(HttpJsonClientCallImpl.java:557)
	at com.google.api.gax.httpjson.HttpJsonClientCallImpl.notifyListeners(HttpJsonClientCallImpl.java:395)
	at com.google.api.gax.httpjson.HttpJsonClientCallImpl.deliver(HttpJsonClientCallImpl.java:322)
	at com.google.api.gax.httpjson.HttpJsonClientCallImpl.setResult(HttpJsonClientCallImpl.java:168)
	at com.google.api.gax.httpjson.HttpRequestRunnable.run(HttpRequestRunnable.java:149)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call([Executors.java:515](https://cs.corp.google.com/#search/&sq=package:%5Epiper$%20project:openjdk25&q=java/util/concurrent/Executors.java:515))
	at java.base/java.util.concurrent.FutureTask.run([FutureTask.java:264](https://cs.corp.google.com/#search/&sq=package:%5Epiper$%20project:openjdk25&q=java/util/concurrent/FutureTask.java:264))
	at java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run([ScheduledThreadPoolExecutor.java:304](https://cs.corp.google.com/#search/&sq=package:%5Epiper$%20project:openjdk25&q=java/util/concurrent/ScheduledThreadPoolExecutor.java:304))
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker([ThreadPoolExecutor.java:1128](https://cs.corp.google.com/#search/&sq=package:%5Epiper$%20project:openjdk25&q=java/util/concurrent/ThreadPoolExecutor.java:1128))
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run([ThreadPoolExecutor.java:628](https://cs.corp.google.com/#search/&sq=package:%5Epiper$%20project:openjdk25&q=java/util/concurrent/ThreadPoolExecutor.java:628))
	at java.base/java.lang.Thread.run([Thread.java:829](https://cs.corp.google.com/#search/&sq=package:%5Epiper$%20project:openjdk25&q=java/lang/Thread.java:829))
	Suppressed: com.google.api.gax.rpc.AsyncTaskException: Asynchronous task failed
		at com.google.api.gax.rpc.ApiExceptions.callAndTranslateApiException(ApiExceptions.java:57)
		at com.google.api.gax.rpc.UnaryCallable.call(UnaryCallable.java:112)
		at com.google.showcase.v1beta1.EchoClient.echo(EchoClient.java:470)
		at com.google.showcase.v1beta1.it.ITOtelTracing.lambda$testTracing_retry_httpjson$10(ITOtelTracing.java:492)
		at org.junit.Assert.assertThrows(Assert.java:1001)
		at org.junit.Assert.assertThrows(Assert.java:981)
		at com.google.showcase.v1beta1.it.ITOtelTracing.testTracing_retry_httpjson(ITOtelTracing.java:492)
		at java.base/java.lang.reflect.Method.invoke([Method.java:566](https://cs.corp.google.com/#search/&sq=package:%5Epiper$%20project:openjdk25&q=java/lang/reflect/Method.java:566))
		at java.base/java.util.ArrayList.forEach([ArrayList.java:1541](https://cs.corp.google.com/#search/&sq=package:%5Epiper$%20project:openjdk25&q=java/util/ArrayList.java:1541))
		at java.base/java.util.ArrayList.forEach([ArrayList.java:1541](https://cs.corp.google.com/#search/&sq=package:%5Epiper$%20project:openjdk25&q=java/util/ArrayList.java:1541))
Caused by: java.net.ConnectException: Connection refused (Connection refused)
	at java.base/java.net.PlainSocketImpl.socketConnect(Native Method)
	at java.base/java.net.AbstractPlainSocketImpl.doConnect([AbstractPlainSocketImpl.java:412](https://cs.corp.google.com/#search/&sq=package:%5Epiper$%20project:openjdk25&q=java/net/AbstractPlainSocketImpl.java:412))
	at java.base/java.net.AbstractPlainSocketImpl.connectToAddress([AbstractPlainSocketImpl.java:255](https://cs.corp.google.com/#search/&sq=package:%5Epiper$%20project:openjdk25&q=java/net/AbstractPlainSocketImpl.java:255))
	at java.base/java.net.AbstractPlainSocketImpl.connect([AbstractPlainSocketImpl.java:237](https://cs.corp.google.com/#search/&sq=package:%5Epiper$%20project:openjdk25&q=java/net/AbstractPlainSocketImpl.java:237))
	at java.base/java.net.Socket.connect([Socket.java:609](https://cs.corp.google.com/#search/&sq=package:%5Epiper$%20project:openjdk25&q=java/net/Socket.java:609))
	at java.base/sun.net.NetworkClient.doConnect([NetworkClient.java:177](https://cs.corp.google.com/#search/&sq=package:%5Epiper$%20project:openjdk25&q=sun/net/NetworkClient.java:177))
	at java.base/sun.net.www.http.HttpClient.openServer([HttpClient.java:508](https://cs.corp.google.com/#search/&sq=package:%5Epiper$%20project:openjdk25&q=sun/net/www/http/HttpClient.java:508))
	at java.base/sun.net.www.http.HttpClient.openServer([HttpClient.java:603](https://cs.corp.google.com/#search/&sq=package:%5Epiper$%20project:openjdk25&q=sun/net/www/http/HttpClient.java:603))
	at java.base/sun.net.www.http.HttpClient.<init>(HttpClient.java:276)
	at java.base/[sun.net.www.http.HttpClient.New](https://www.google.com/url?q=http://sun.net.www.http.HttpClient.New&sa=D)(HttpClient.java:375)
	at java.base/[sun.net.www.http.HttpClient.New](https://www.google.com/url?q=http://sun.net.www.http.HttpClient.New&sa=D)(HttpClient.java:396)
	at java.base/sun.net.www.protocol.http.HttpURLConnection.getNewHttpClient([HttpURLConnection.java:1253](https://cs.corp.google.com/#search/&sq=package:%5Epiper$%20project:openjdk25&q=sun/net/www/protocol/http/HttpURLConnection.java:1253))
	at java.base/sun.net.www.protocol.http.HttpURLConnection.plainConnect0([HttpURLConnection.java:1187](https://cs.corp.google.com/#search/&sq=package:%5Epiper$%20project:openjdk25&q=sun/net/www/protocol/http/HttpURLConnection.java:1187))
	at java.base/sun.net.www.protocol.http.HttpURLConnection.plainConnect([HttpURLConnection.java:1081](https://cs.corp.google.com/#search/&sq=package:%5Epiper$%20project:openjdk25&q=sun/net/www/protocol/http/HttpURLConnection.java:1081))
	at java.base/sun.net.www.protocol.http.HttpURLConnection.connect([HttpURLConnection.java:1015](https://cs.corp.google.com/#search/&sq=package:%5Epiper$%20project:openjdk25&q=sun/net/www/protocol/http/HttpURLConnection.java:1015))
	at java.base/sun.net.www.protocol.http.HttpURLConnection.getOutputStream0([HttpURLConnection.java:1367](https://cs.corp.google.com/#search/&sq=package:%5Epiper$%20project:openjdk25&q=sun/net/www/protocol/http/HttpURLConnection.java:1367))
	at java.base/sun.net.www.protocol.http.HttpURLConnection.getOutputStream([HttpURLConnection.java:1342](https://cs.corp.google.com/#search/&sq=package:%5Epiper$%20project:openjdk25&q=sun/net/www/protocol/http/HttpURLConnection.java:1342))
	at com.google.api.client.http.javanet.NetHttpRequest.execute(NetHttpRequest.java:113)
	at com.google.api.client.http.javanet.NetHttpRequest.execute(NetHttpRequest.java:84)
	at com.google.api.client.http.HttpRequest.execute(HttpRequest.java:1012)
	at com.google.api.gax.httpjson.HttpRequestRunnable.run(HttpRequestRunnable.java:115)
	... 6 more

12:16:17:477 [INFO] Running com.google.showcase.v1beta1.it.ITBidiStreaming

@suztomo
Copy link
Copy Markdown
Member Author

suztomo commented Apr 24, 2026

As per #12916, the showcase integration test getting stuck is not caused by this pull ruquest.

@suztomo suztomo marked this pull request as ready for review April 24, 2026 15:08
@suztomo suztomo requested review from a team as code owners April 24, 2026 15:08
<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
<version>4.13.2</version>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this because there are some tests still use junit 4? We should've migrated all tests to junit 5.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<artifactId>maven-dependency-plugin</artifactId>
<configuration>
<ignoredUnusedDeclaredDependencies>
<ignoredUnusedDeclaredDependency>com.google.api.grpc:proto-google-iam-v1</ignoredUnusedDeclaredDependency>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove this unused dependency in showcase? Also it's fine to not enable dependencies check for showcase.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now showcase skips maven-dependency-plugin analysis.

<configuration>
<ignoredUnusedDeclaredDependencies>
<ignoredUnusedDeclaredDependency>com.google.errorprone:error_prone_annotations</ignoredUnusedDeclaredDependency>
<ignoredUnusedDeclaredDependency>org.junit.jupiter:junit-jupiter-engine</ignoredUnusedDeclaredDependency>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see there is a ignoreNonCompile option, can we use it so that we don't have to ignore test dependencies?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. Added to sdk-platform-java/gapic-generator-java-pom-parent/pom.xml.

Comment thread sdk-platform-java/gapic-generator-java/pom.xml Outdated
@suztomo suztomo requested a review from a team as a code owner April 24, 2026 16:36
@snippet-bot
Copy link
Copy Markdown

snippet-bot Bot commented Apr 24, 2026

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@suztomo suztomo force-pushed the bring-back-dependencies-check branch 4 times, most recently from 92c8c3f to 9bf60a9 Compare April 24, 2026 16:43
@suztomo suztomo requested a review from blakeli0 April 24, 2026 17:34
<ignoredUnusedDeclaredDependency>io.grpc:grpc-netty-shaded</ignoredUnusedDeclaredDependency>
<ignoredUnusedDeclaredDependency>io.grpc:grpc-googleapis</ignoredUnusedDeclaredDependency>
<ignoredUnusedDeclaredDependency>org.slf4j:slf4j-api</ignoredUnusedDeclaredDependency>
<ignoredUnusedDeclaredDependency>io.grpc:grpc-s2a</ignoredUnusedDeclaredDependency>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems is only used in tests, we should be able to remove it from here.

@suztomo suztomo force-pushed the bring-back-dependencies-check branch from 9bf60a9 to 7e5f23b Compare April 24, 2026 18:26
@suztomo
Copy link
Copy Markdown
Member Author

suztomo commented Apr 24, 2026

[INFO] --- dependency:3.8.1:analyze (default-cli) @ google-cloud-bigquery-jdbc ---
Error:  Used undeclared dependencies found:
Error:     junit:junit:jar:4.13.2:test

@suztomo suztomo requested a review from blakeli0 April 24, 2026 19:06
@suztomo
Copy link
Copy Markdown
Member Author

suztomo commented Apr 24, 2026

The spanner unit test is running more than 1 hour 10 mins.

@suztomo
Copy link
Copy Markdown
Member Author

suztomo commented Apr 24, 2026

I think the spanner test is stuck:

18:30:50:970 [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 s -- in com.google.cloud.spanner.ValueBinderTest
18:30:50:973 [INFO] Running com.google.cloud.spanner.AsyncResultSetImplTest

@suztomo suztomo force-pushed the bring-back-dependencies-check branch from 7e5f23b to 9c31a98 Compare April 24, 2026 20:28
@suztomo
Copy link
Copy Markdown
Member Author

suztomo commented Apr 24, 2026

All checks have passsed.

@suztomo suztomo merged commit d1585fc into googleapis:main Apr 24, 2026
258 of 259 checks passed
@suztomo suztomo deleted the bring-back-dependencies-check branch April 24, 2026 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[sdk-platform-java] Re-enable dependencies check for handwritten modules

2 participants