ci: bring the dependencies check back#12906
Conversation
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
|
It detected bad dependency tree. |
|
Dependency graph of the cab-token module |
52456a1 to
b2434ca
Compare
|
d15dc2e to
6c3a3d6
Compare
|
f305894 to
f922731
Compare
|
As per #12916, the showcase integration test getting stuck is not caused by this pull ruquest. |
| <dependency> | ||
| <groupId>junit</groupId> | ||
| <artifactId>junit</artifactId> | ||
| <version>4.13.2</version> |
There was a problem hiding this comment.
Is this because there are some tests still use junit 4? We should've migrated all tests to junit 5.
There was a problem hiding this comment.
I see many are still using "org.junit.Test".
| <artifactId>maven-dependency-plugin</artifactId> | ||
| <configuration> | ||
| <ignoredUnusedDeclaredDependencies> | ||
| <ignoredUnusedDeclaredDependency>com.google.api.grpc:proto-google-iam-v1</ignoredUnusedDeclaredDependency> |
There was a problem hiding this comment.
Can we remove this unused dependency in showcase? Also it's fine to not enable dependencies check for showcase.
There was a problem hiding this comment.
Now showcase skips maven-dependency-plugin analysis.
| <configuration> | ||
| <ignoredUnusedDeclaredDependencies> | ||
| <ignoredUnusedDeclaredDependency>com.google.errorprone:error_prone_annotations</ignoredUnusedDeclaredDependency> | ||
| <ignoredUnusedDeclaredDependency>org.junit.jupiter:junit-jupiter-engine</ignoredUnusedDeclaredDependency> |
There was a problem hiding this comment.
I see there is a ignoreNonCompile option, can we use it so that we don't have to ignore test dependencies?
There was a problem hiding this comment.
Good idea. Added to sdk-platform-java/gapic-generator-java-pom-parent/pom.xml.
No region tags are edited in this PR.This comment is generated by snippet-bot.
|
92c8c3f to
9bf60a9
Compare
| <ignoredUnusedDeclaredDependency>io.grpc:grpc-netty-shaded</ignoredUnusedDeclaredDependency> | ||
| <ignoredUnusedDeclaredDependency>io.grpc:grpc-googleapis</ignoredUnusedDeclaredDependency> | ||
| <ignoredUnusedDeclaredDependency>org.slf4j:slf4j-api</ignoredUnusedDeclaredDependency> | ||
| <ignoredUnusedDeclaredDependency>io.grpc:grpc-s2a</ignoredUnusedDeclaredDependency> |
There was a problem hiding this comment.
It seems is only used in tests, we should be able to remove it from here.
9bf60a9 to
7e5f23b
Compare
|
|
The spanner unit test is running more than 1 hour 10 mins. |
|
I think the spanner test is stuck: |
This change adds the dependencies check back to the ci.yaml, google-auth-library-java-ci.yaml, and sdk-platform-java-ci.yaml. This removes unnecessary java version matrix logic in existing dependencies check. Java 17 just works fine. Fixes googleapis#12895
7e5f23b to
9c31a98
Compare
|
All checks have passsed. |
This change adds the dependencies check back to the ci.yaml, google-auth-library-java-ci.yaml, and sdk-platform-java-ci.yaml.
This pull request removes unnecessary java version matrix logic in existing dependencies check. Java 17 just works fine.
This pull request removes the retry logic in dependencies.sh because at the time this Maven command runs Maven's dependency resolution, which may hit transient errors for network connection, is already done.
ignoreNonCompile property is maven-dependency-plugin's property to skip non-compile dependencies. https://maven.apache.org/plugins/maven-dependency-plugin/analyze-only-mojo.html#ignorenoncompile
This is useful to skip test scope dependencies because they do not go to library users' class path.
Fixes #12895
b/505481903