Draft
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds unnecessary trailing empty lines to the ITBidiStreaming.java test file. The review feedback correctly identifies these as style violations and notes that the current changes do not align with the PR's objective of implementing showcase tests in CI.
Comment on lines
+108
to
+110
|
|
||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
These trailing empty lines are unnecessary and should be removed to maintain code quality. Additionally, the current changes do not implement the 'running showcase test in CI' task described in the PR title.
References
- According to standard Java coding practices (e.g., Google Java Style Guide), files should end with a single newline character. Multiple trailing empty lines are unnecessary and should be avoided. (link)
Member
Author
|
It hit connection refused error, which makes the integration test stuck. https://source.cloud.google.com/results/invocations/d35376e5-0052-4c8d-a9fc-bc118fcad3ce (Click "Test Fusion" -> "Build Log") |
Contributor
|
This should have been fixed in #12922 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checking the
com.google.showcase.v1beta1.it.ITBidiStreamingtest failure (connection closed) observed in #12906 (comment).