ci: add librarian library generation workflow#13284
Merged
Merged
Conversation
Create a new GitHub workflow librarian_library_generation.yaml to run librarian generate --all on PRs and verify that the output is identical to the checked-in code. Fixes googleapis/librarian#5240
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
zhumin8
reviewed
May 28, 2026
zhumin8
reviewed
May 28, 2026
Co-authored-by: Min Zhu <zhumin@google.com>
Co-authored-by: Min Zhu <zhumin@google.com>
zhumin8
reviewed
May 29, 2026
zhumin8
approved these changes
May 29, 2026
JoeWang1127
reviewed
May 29, 2026
| # limitations under the License. | ||
| name: Librarian generate diff check on pull requests | ||
| on: | ||
| pull_request: |
Contributor
There was a problem hiding this comment.
How long does it take to run this workflow. If it's too long, e.g., > 10 mins, it may not be suitable for a presubmit.
Contributor
Author
There was a problem hiding this comment.
Definitely longer than 10 min, closer to an hour.
Contributor
There was a problem hiding this comment.
Definitely longer than 10 min, closer to an hour.
How about converting it to a postsubmit?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create a new GitHub workflow librarian_library_generation.yaml to run librarian generate --all on PRs and verify that the output is identical to the checked-in code.
For googleapis/librarian#5240