-
Notifications
You must be signed in to change notification settings - Fork 1.1k
ci: add librarian library generation workflow #13284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+68
−0
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
0cffeb6
ci: add librarian library generation workflow
sofisl 4135b45
Update librarian installation and protoc version
sofisl a77eb59
Merge branch 'main' into add-librarian-workflow
sofisl 7000662
Update .github/workflows/librarian_library_generation.yaml
sofisl 02ba819
Update .github/workflows/librarian_library_generation.yaml
sofisl 883ae78
Add librarian_generation_check workflow
sofisl 056f31d
chore: remove fork and token stuff
sofisl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| # Copyright 2026 Google LLC | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| name: Librarian generate diff check on pull requests | ||
| on: | ||
| pull_request: | ||
|
|
||
| jobs: | ||
| library_generation: | ||
| runs-on: ubuntu-24.04 | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 0 | ||
| - uses: actions/setup-go@v5 | ||
| with: | ||
| go-version: 'stable' | ||
| - name: Install Librarian | ||
| run: | | ||
| V=$(go run github.com/googleapis/librarian/cmd/librarian@latest config get version) | ||
| echo "Installing librarian version $V" | ||
| go install github.com/googleapis/librarian/cmd/librarian@$V | ||
| - name: Install protoc | ||
| run: | | ||
| set -e | ||
| VERSION="33.2" | ||
| curl -fsSL --retry 5 --retry-delay 15 -o /tmp/protoc.zip "https://github.com/protocolbuffers/protobuf/releases/download/v$VERSION/protoc-$VERSION-linux-x86_64.zip" | ||
| cd /usr/local | ||
| sudo unzip -o /tmp/protoc.zip | ||
| protoc --version | ||
| - uses: actions/setup-java@v4 | ||
| with: | ||
| java-version: "17" | ||
| distribution: "temurin" | ||
| cache: "maven" | ||
| - name: Verify Java and Maven installation | ||
| run: | | ||
| java -version | ||
| if ! command -v mvn &> /dev/null; then | ||
| sudo apt-get update && sudo apt-get install -y maven | ||
| fi | ||
| mvn -version | ||
| - uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: "3.12" | ||
| cache: 'pip' | ||
| - name: Run librarian install | ||
| run: | | ||
| librarian install | ||
| echo "$HOME/java_tools/bin" >> $GITHUB_PATH | ||
| - name: Run librarian generate | ||
| env: | ||
| PYTHONPATH: ${{ github.workspace }}/sdk-platform-java/hermetic_build/library_generation/owlbot | ||
| run: | | ||
| librarian generate --all | ||
| - name: Check for generated code changes | ||
| run: | | ||
| git diff --exit-code | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How long does it take to run this workflow. If it's too long, e.g., > 10 mins, it may not be suitable for a presubmit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely longer than 10 min, closer to an hour.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about converting it to a postsubmit?