deps(shared-deps): migrate awaitility to shared-dependencies#13671
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request centralizes the dependency management for Awaitility by removing the local version property and dependency version declaration from the google-cloud-spanner POM, and moving the awaitility dependency definition to the shared third-party-dependencies POM. There are no review comments, and I have no feedback to provide.
blakeli0
reviewed
Jul 7, 2026
Move awaitility dependency management to java-shared-dependencies so that it can be managed centrally in the monorepo. Remove local awaitility version override from java-spanner. TAG=agy CONV=d1b443f9-5dae-4a94-afc1-e1c33d78a802
Remove local awaitility version override from java-datastore. TAG=agy CONV=d1b443f9-5dae-4a94-afc1-e1c33d78a802
Bump logback-classic to 1.5.33 in google-cloud-jar-parent to match logback-core. Remove local logback-classic override in google-cloud-storage which was causing AbstractMethodError due to version mismatch. TAG=agy CONV=d1b443f9-5dae-4a94-afc1-e1c33d78a802
…lity Override both logback-classic and logback-core to 1.3.16 in google-cloud-storage to support running tests on Java 8 runtime, as Logback 1.5.x requires Java 11+. TAG=agy CONV=d1b443f9-5dae-4a94-afc1-e1c33d78a802
…e override Add a `java8-logback` profile in `google-cloud-jar-parent` to downgrade logback dependencies to `1.3.16` when running on Java 8. Remove the hardcoded override in `google-cloud-storage` to keep default behavior on Java 11+ at 1.5.33 while maintaining Java 8 test runtime compatibility. TAG=agy CONV=d1b443f9-5dae-4a94-afc1-e1c33d78a802
lqiu96
force-pushed
the
migrate-awaitility-shared-deps
branch
from
7af17d4 to
432e1a8
Compare
Move the `java8-logback` profile from `google-cloud-jar-parent` to `java-storage/pom.xml` (Storage Parent) since Java 8 compatibility for tests is primarily needed/used in the Storage module. Add explanatory comments regarding Logback 1.5.x Java 11+ requirement and the need to downgrade to 1.3.x for Java 8 runtimes. TAG=agy CONV=d1b443f9-5dae-4a94-afc1-e1c33d78a802
Revert all logback-related changes (alignment and Java 8 profile) from this branch to keep it strictly focused on Awaitility migration. The logback changes will be submitted in a separate PR. TAG=agy CONV=d1b443f9-5dae-4a94-afc1-e1c33d78a802
jinseopkim0
approved these changes
Jul 7, 2026
lqiu96
added
the
kokoro:force-run
|
yoshi-kokoro
removed
the
kokoro:force-run
|
lqiu96
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move awaitility dependency management to java-shared-dependencies so that it can be managed centrally in the monorepo. Remove local awaitility version override from java-spanner.