test(pubsub): fix JSpecify compatibility issues on Java 8 for Mockito tests#13808
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the unit tests in MessageDispatcherTest and StreamingSubscriberConnectionTest. Specifically, it updates mock creation to consistently use withSettings().withoutAnnotations() and refactors StreamingSubscriberConnectionTest to use class-level mock callables (mockStreamingCallable, mockAcknowledgeCallable, and mockModifyAckDeadlineCallable) instead of relying on deep stubbing of SubscriberStub. This simplifies the test setup and reduces redundant mock creation in individual test cases. There are no review comments to address.
… tests Update Mockito mocks in pubsub tests to use `withSettings().withoutAnnotations()` to avoid `ArrayStoreException` on Java 8 due to JSpecify's `@NullMarked` annotation. Explicitly mock callables instead of relying on `RETURNS_DEEP_STUBS` which does not propagate the settings. TAG=agy CONV=de3ef09d-a26c-4190-b578-4c993f807bdc
…rConnectionTest Stub mock callables to return pending SettableApiFuture and default ClientStream to avoid NullPointerException during connection startup and operation in tests. TAG=agy CONV=de3ef09d-a26c-4190-b578-4c993f807bdc
lqiu96
force-pushed
the
fix-jspecify-ci-pubsub-mockito
branch
from
July 17, 2026 20:00
b675143 to
dbd89d6
Compare
lqiu96
marked this pull request as ready for review
July 17, 2026 20:05
michaelpri10
approved these changes
Jul 17, 2026
lqiu96
enabled auto-merge (squash)
July 17, 2026 20:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Mockito mocks in pubsub tests to use
withSettings().withoutAnnotations()to avoidArrayStoreExceptionon Java 8 due to JSpecify's@NullMarkedannotation. Explicitly mock callables instead of relying onRETURNS_DEEP_STUBSwhich does not propagate the settings.