Skip to content

ci(bigtable): allow bulkTests profile to skip unit tests by removing explicit skipTests override - #13906

Merged
lqiu96 merged 1 commit into
mainfrom
fix/disable-bigtable-timeout-tests
Jul 27, 2026
Merged

ci(bigtable): allow bulkTests profile to skip unit tests by removing explicit skipTests override#13906
lqiu96 merged 1 commit into
mainfrom
fix/disable-bigtable-timeout-tests

Conversation

@lqiu96

@lqiu96 lqiu96 commented Jul 27, 2026

Copy link
Copy Markdown
Member

The normal CI units is running the BigTable tests even though bigtable has their own split-units config.

This seems to stem from bulkTest profile having the skipTests property be overwritten by BigTable's default config. This change updates it so that bulkTests profile can properly skip BigTable tests when enabled. When the profile is not enabled, the skipTests property defaults to "" which is evaluated to false by default.

@lqiu96
lqiu96 force-pushed the fix/disable-bigtable-timeout-tests branch from 58adf67 to b225abe Compare July 27, 2026 18:48

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the <skipTests>false</skipTests> property from the pom.xml file in google-cloud-bigtable. I have no feedback to provide.

@lqiu96
lqiu96 requested a review from mutianf July 27, 2026 18:49
@lqiu96
lqiu96 marked this pull request as ready for review July 27, 2026 18:49
@lqiu96
lqiu96 requested review from a team as code owners July 27, 2026 18:49
@lqiu96
lqiu96 enabled auto-merge (squash) July 27, 2026 18:58
@lqiu96
lqiu96 merged commit 8472b08 into main Jul 27, 2026
211 of 213 checks passed
@lqiu96
lqiu96 deleted the fix/disable-bigtable-timeout-tests branch July 27, 2026 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants