Skip to content

fix(java-sql): temp fix for lint and skip generate - #14005

Open
zhumin8 wants to merge 2 commits into
googleapis:mainfrom
zhumin8:skip-sql
Open

fix(java-sql): temp fix for lint and skip generate#14005
zhumin8 wants to merge 2 commits into
googleapis:mainfrom
zhumin8:skip-sql

Conversation

@zhumin8

@zhumin8 zhumin8 commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Temp fix for lint issue and skip generate to avoid this overriden by generation run.

This is a temporarily solution to unblock development (e.g., #13928), while we figure out a longer term solution.

For googleapis/librarian#7146

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request cleans up extra blank lines in several Java gRPC service files and configures skip_generate: true for the Java library in librarian.yaml. There are no review comments, so I have no feedback to provide.

@zhumin8
zhumin8 marked this pull request as ready for review August 6, 2026 07:53
@zhumin8
zhumin8 requested review from a team as code owners August 6, 2026 07:53
Comment thread librarian.yaml
- path: google/cloud/location/locations.proto
java:
released_version: 0.1.0
skip_generate: true

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it mean this library will not be regenerated when we run librarian generate?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants