pubsub: reverse the padding direction - #2478
Closed
pongad wants to merge 2 commits into
Closed
Conversation
Previously, padding works by sending deadline extension before messages expire. Eg, if message expires in 10 seconds, we try to send extension in 9 seconds. A problem is with high latency, highly congested, or highly buffered connections. If we want the server to expire messages in 10 seconds, there is no way to set 10 seconds for more of padding. This commit reverse the padding direction. Eg, if we want the message to expire in 10 seconds, we send the extension at 10 seconds, but we ask the server for 11 seconds. In this way, if we want the padding to be 10 seconds, we just ask the server for 20 seconds. This logic only works for streaming pull though, as streaming pull allows deadline to be changed individually for each stream. Consequently, the tests are changed to reflect the new logic and the relevant tests are disabled for polling pull. This commit also increases the default padding to 5 seconds, since high latency has been observed in production. Fixes #2465.
googlebot
added
the
cla: yes
Contributor
Author
| private static final int INITIAL_ACK_DEADLINE_EXTENSION_SECONDS = 2; | ||
| @VisibleForTesting static final Duration PENDING_ACKS_SEND_DELAY = Duration.ofMillis(100); | ||
| private static final int MAX_ACK_DEADLINE_EXTENSION_SECS = 10 * 60; // 10m | ||
| static final Duration MAX_ACK_DEADLINE = Duration.ofSeconds(600); // 10m |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
|
||
| public void setMessageDeadlineSeconds(int messageDeadlineSeconds) { | ||
| this.messageDeadlineSeconds.set(messageDeadlineSeconds); | ||
| public void setMessageDeadline(Duration dur) { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
|
||
| /* | ||
| We define 3 forms of deadline: | ||
| 1. intendedDeadline: The amount of time we take to process a message. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
Author
|
pubsub team is going with a different solution. closing this. |
chingor13
pushed a commit
that referenced
this pull request
Feb 20, 2026
…plugin to v3.1.2 (#2478) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.apache.maven.plugins:maven-deploy-plugin](https://maven.apache.org/plugins/) | `3.1.1` -> `3.1.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/googleapis/java-bigquerystorage). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMjEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjMyMS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
chingor13
pushed a commit
that referenced
this pull request
Mar 30, 2026
…37.0 (#2478) * chore(deps): update dependency com.google.cloud:libraries-bom to v26.37.0 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
benjaminp
pushed a commit
to benjaminp/google-cloud-java
that referenced
this pull request
Jul 13, 2026
](https://renovatebot.com){kind=link}
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, padding works by sending deadline extension before
messages expire.
Eg, if message expires in 10 seconds, we try to send extension
in 9 seconds.
A problem is with high latency, highly congested, or highly buffered
connections.
If we want the server to expire messages in 10 seconds,
there is no way to set 10 seconds for more of padding.
This commit reverse the padding direction.
Eg, if we want the message to expire in 10 seconds, we send the
extension at 10 seconds, but we ask the server for 11 seconds.
In this way, if we want the padding to be 10 seconds, we just
ask the server for 20 seconds.
This logic only works for streaming pull though,
as streaming pull allows deadline to be changed individually
for each stream.
Consequently, the tests are changed to reflect the new logic
and the relevant tests are disabled for polling pull.
This commit also increases the default padding to 5 seconds,
since high latency has been observed in production.
Fixes #2465.