Add support for Cloud Functions

[jmdobry]

• - GAPIC code
• - Implementation
  • - Functions#cloudfunction
  • - Functions#createFunction
  • - Functions#getFunctions
  • - Functions#getFunctionsStream
  • - Functions#operation
  • - CloudFunction#call
  • - CloudFunction#create
  • - CloudFunction#delete
  • - CloudFunction#exists
  • - CloudFunction#get
  • - CloudFunction#setMetadata
• - unit tests
• - system tests
• - docs

[jmdobry]

@stephenplusplus @callmehiphop

The Cloud Functions API ListFunctions method doesn't support pagination yet. I attempted to use the paginator for the getFunctions method, but limiting doesn't appear work. Here's the skipped test.

The PR is done (except for docs), barring any requested changes during review.

I experimentally implemented this PR using some ES2015 features (see #1855), and set the engines field in package.json to "node": ">=4.3.2" (it's the oldest 4.x version shown at node.green. I imagine the @google-cloud/functions package will be "alpha" for a while, then "beta", and by the time it's GA google-cloud-node will have dropped support for Node.js 0.12, so perhaps it can be a pilot for #1855.

[ofrobots]

@jmdobry not sure what view you're seeing, I do see more recent versions of Node.js 4.x on node.green (not that there is a difference in the list of supported language features that I am aware of between 4.3.x and 4.7.x)

[jmdobry]

I see the more recent 4.x versions too, but I thought it was prudent to stay compatible with older 4.x versions.

[jmdobry]

Instead of dropping support for 0.10 and 0.12 straight away in google-auth-library-nodejs, perhaps a better experiment would be to drop support for 0.10 and 0.12 in a brand new package, such as this one.

[stephenplusplus]

What's the plan / status of this?

[jmdobry]

Good question. cc @omaray

Option 1

Continue forward with this PR. There have been many changes to the google-cloud-node common libraries since I submitted this, so it's needs some work to get up-to-date. When I left off the PR was ready for review.

Option 2

Expose the Gapic code to the user and delete the majority of my handwritten code, keeping only the helper function that zips and uploads a directory to Google Cloud Storage in preparation for creating/deploying a new Cloud Function (because it's a beast, and I'd hate to have to make users do all that themselves).

[lukesneeringer]

Instead of dropping support for 0.10 and 0.12 straight away in google-auth-library-nodejs, perhaps a better experiment would be to drop support for 0.10 and 0.12 in a brand new package, such as this one.
👍 1

Worth noting: This has been adjudicated already. 0.12 support is gone.

[lukesneeringer]

Option 1

Continue forward with this PR. There have been many changes to the google-cloud-node common libraries since I submitted this, so it's needs some work to get up-to-date. When I left off the PR was ready for review.

Option 2

Expose the Gapic code to the user and delete the majority of my handwritten code, keeping only the helper function that zips and uploads a directory to Google Cloud Storage in preparation for creating/deploying a new Cloud Function (because it's a beast, and I'd hate to have to make users do all that themselves).

Our team is working on the concept of a "partial GAPIC", which is basically option 2. We should almost certainly do that. I should have a design doc soon and this could be a useful proof case for it.