Skip to content

Comments

A few unit tests#6

Merged
pmuens merged 2 commits intoserverless:masterfrom
RomanHotsiy:master
Feb 1, 2017
Merged

A few unit tests#6
pmuens merged 2 commits intoserverless:masterfrom
RomanHotsiy:master

Conversation

@RomanHotsiy
Copy link
Contributor

Started adding unit tests (#2)

@nikgraf
Copy link

nikgraf commented Nov 15, 2016

nice, looks good to me 👌
@pmuens you better double-check as you know the code better :)

@pmuens
Copy link
Contributor

pmuens commented Nov 16, 2016

Damn @RomanGotsiy you rock! 🎉

Thanks for getting this started! I'll look into it ASAP!

@pmuens
Copy link
Contributor

pmuens commented Feb 1, 2017

Hey @RomanGotsiy thank you very much for that!

I'll merge it now so that you appear as a contributor in the GitHub contributors list!
We'll re-write this plugin the upcoming days and will wipe out everything so that we have a blank slate. We'll write it in a way where we utilize the the official Node.js Google Cloud Functions package (see: googleapis/google-cloud-node#1688) in combination with the Google Deployment Manager for the needed infrastructure.

However we're constantly looking back at the stuff which was done here (some tings can be copied and pasted) and will use your tests as well.

So thanks again 🙌

@pmuens pmuens merged commit 1100f34 into serverless:master Feb 1, 2017
@RomanHotsiy
Copy link
Contributor Author

RomanHotsiy commented Feb 1, 2017

woohooo - that was fast 🚀 😂
@pmuens thank you! You're so attentive 😄

I'm happy that project is evolving 👍
Will be happy to help out with tests in the future 🙌

@pmuens
Copy link
Contributor

pmuens commented Feb 1, 2017

😄 yes, sorry for the slow response but we had some discussions how this project should evolve.

Will be happy to help out with tests in the future

Awesome! That's good to hear. Thanks for offering help here 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants