Skip to content

chore: remove trailing comma from samples package.json - #8402

Merged
pearigee merged 1 commit into
mainfrom
fix-container-samples-json
May 29, 2026
Merged

chore: remove trailing comma from samples package.json#8402
pearigee merged 1 commit into
mainfrom
fix-container-samples-json

Conversation

@suztomo

@suztomo suztomo commented May 29, 2026

Copy link
Copy Markdown
Member

This PR removes a trailing comma in packages/google-container/samples/package.json, which causes parsing errors in strict JSON parsers (like Node's native JSON.parse) used by tools like release-please.

3ec901e#diff-aec042da7074a44cd5a6571d394170cd0f00db02b69a120d2bf9455e20577e31 was the commit that introduced the trailing comma.

Fixes: b/518016608 "release-please: Expected double-quoted property name in JSON at position 365"

This prevents JSON parsing errors in release-please and other strict tools.
@suztomo
suztomo requested a review from a team as a code owner May 29, 2026 22:32
@product-auto-label product-auto-label Bot added the samples Issues that are directly related to samples. label May 29, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes a trailing comma from the dependencies block in the samples package.json file for google-container. There are no review comments, and I have no feedback to provide.

@pearigee
pearigee merged commit 371ea4d into main May 29, 2026
31 checks passed
@pearigee
pearigee deleted the fix-container-samples-json branch May 29, 2026 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants