Skip to content

feat: update API sources and regenerate - #8999

Merged
quirogas merged 1 commit into
googleapis:mainfrom
quirogas:chore-update-librarian-2026-07-28
Jul 29, 2026
Merged

feat: update API sources and regenerate#8999
quirogas merged 1 commit into
googleapis:mainfrom
quirogas:chore-update-librarian-2026-07-28

Conversation

@quirogas

@quirogas quirogas commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@quirogas quirogas self-assigned this Jul 28, 2026
@quirogas
quirogas requested a review from a team as a code owner July 28, 2026 22:57
@github-actions
github-actions Bot requested a review from feywind July 28, 2026 22:57
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Jul 28, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces several new protocol buffer definitions and service methods for the Google Ads Ad Manager API, including support for Creative Sets, Slates, and various batch operations for Orders, Slates, and Targeting Presets. It also updates the corresponding client libraries and generated samples. I have identified an issue in the generated sample for BatchCreateOrders, where the requests parameter uses an incorrect placeholder structure, and I recommend updating it to reflect the expected array of CreateOrderRequest objects.

Comment thread packages/google-ads-admanager/samples/generated/v1/order_service.batch_create_orders.js
* Required. The `Order` objects to create.
* A maximum of 100 objects can be created in a batch.
*/
// const requests = [1,2,3,4]

@gemini-code-assist gemini-code-assist Bot Jul 28, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The placeholder value for requests is [1,2,3,4], which is incorrect for an array of CreateOrderRequest objects. This could be improved to show the correct structure, for example: // const requests = [ { parent: 'networks/123', order: { /* ... */ } } ];. This would provide a more accurate example for users. This issue appears to be present in other newly generated batch request samples as well.

@quirogas

quirogas commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

Once the changes to compute are released, they should address #8971

@quirogas
quirogas merged commit 5c36365 into googleapis:main Jul 29, 2026
35 checks passed
@release-please release-please Bot mentioned this pull request Jul 28, 2026
Merged
quirogas pushed a commit that referenced this pull request Jul 29, 2026
@release-please
chore: release main (#8986)
4785152 
🤖 I have created a release *beep* *boop*
---


<details><summary>jsdoc-region-tag: 5.0.0</summary>

##
[5.0.0](jsdoc-region-tag-v4.0.3...jsdoc-region-tag-v5.0.0)
(2026-07-29)


### ⚠ BREAKING CHANGES

* Update jsdoc-region-tag to minimum Node version of 22.
([#8984](#8984))

### Features

* Update jsdoc-region-tag to minimum Node version of 22.
([#8984](#8984))
([9c26691](9c26691)),
refs
[#8985](#8985)
</details>

<details><summary>pack-n-play: 5.0.0</summary>

##
[5.0.0](pack-n-play-v4.2.3...pack-n-play-v5.0.0)
(2026-07-29)


### ⚠ BREAKING CHANGES

* Update pack-n-play to minimum Node version of 22.
([#8987](#8987))

### Features

* Update pack-n-play to minimum Node version of 22.
([#8987](#8987))
([b61e3d7](b61e3d7)),
refs
[#8985](#8985)
</details>

<details><summary>admanager: 0.8.0</summary>

##
[0.8.0](admanager-v0.7.0...admanager-v0.8.0)
(2026-07-29)


### Features

* Update API sources and regenerate
([#8999](#8999))
([5c36365](5c36365))
</details>

<details><summary>cloudquotas: 2.4.0</summary>

##
[2.4.0](cloudquotas-v2.3.1...cloudquotas-v2.4.0)
(2026-07-29)


### Features

* Update API sources and regenerate
([#8999](#8999))
([5c36365](5c36365))
</details>

<details><summary>chat: 0.27.0</summary>

##
[0.27.0](chat-v0.26.0...chat-v0.27.0)
(2026-07-29)


### Features

* Update API sources and regenerate
([#8999](#8999))
([5c36365](5c36365))
</details>

<details><summary>aiplatform: 6.11.0</summary>

##
[6.11.0](aiplatform-v6.10.0...aiplatform-v6.11.0)
(2026-07-29)


### Features

* Update API sources and regenerate
([#8999](#8999))
([5c36365](5c36365))
</details>

<details><summary>batch: 2.5.0</summary>

##
[2.5.0](batch-v2.4.0...batch-v2.5.0)
(2026-07-29)


### Features

* Update API sources and regenerate
([#8999](#8999))
([5c36365](5c36365))
</details>

<details><summary>commerceproducer: 0.2.0</summary>

##
[0.2.0](commerceproducer-v0.1.0...commerceproducer-v0.2.0)
(2026-07-29)


### Features

* Update API sources and regenerate
([#8999](#8999))
([5c36365](5c36365))
</details>

<details><summary>compute: 6.15.0</summary>

##
[6.15.0](compute-v6.14.0...compute-v6.15.0)
(2026-07-29)


### Features

* Update API sources and regenerate
([#8999](#8999))
([5c36365](5c36365))
</details>

<details><summary>google-cloud-firestore-api: 0.3.0</summary>

##
[0.3.0](google-cloud-firestore-api-v0.2.0...google-cloud-firestore-api-v0.3.0)
(2026-07-29)


### Features

* Update API sources and regenerate
([#8999](#8999))
([5c36365](5c36365))
</details>

<details><summary>network-connectivity: 4.7.0</summary>

##
[4.7.0](network-connectivity-v4.6.1...network-connectivity-v4.7.0)
(2026-07-29)


### Features

* Update API sources and regenerate
([#8999](#8999))
([5c36365](5c36365))
</details>

<details><summary>networkservices: 0.14.0</summary>

##
[0.14.0](networkservices-v0.13.0...networkservices-v0.14.0)
(2026-07-29)


### Features

* Update API sources and regenerate
([#8999](#8999))
([5c36365](5c36365))
</details>

<details><summary>sql: 0.26.0</summary>

##
[0.26.0](sql-v0.25.0...sql-v0.26.0)
(2026-07-29)


### Features

* Update API sources and regenerate
([#8999](#8999))
([5c36365](5c36365))
</details>

<details><summary>support: 2.6.0</summary>

##
[2.6.0](support-v2.5.0...support-v2.6.0)
(2026-07-29)


### Features

* Update API sources and regenerate
([#8999](#8999))
([5c36365](5c36365))
</details>

<details><summary>tasks: 6.3.0</summary>

##
[6.3.0](tasks-v6.2.3...tasks-v6.3.0)
(2026-07-29)


### Features

* Update API sources and regenerate
([#8999](#8999))
([5c36365](5c36365))
</details>

<details><summary>developer-knowledge: 0.3.0</summary>

##
[0.3.0](developer-knowledge-v0.2.0...developer-knowledge-v0.3.0)
(2026-07-29)


### Features

* Update API sources and regenerate
([#8999](#8999))
([5c36365](5c36365))
</details>

<details><summary>containeranalysis: 6.9.0</summary>

##
[6.9.0](containeranalysis-v6.8.0...containeranalysis-v6.9.0)
(2026-07-29)


### Features

* Update API sources and regenerate
([#8999](#8999))
([5c36365](5c36365))
</details>

<details><summary>navconnect: 0.2.0</summary>

##
[0.2.0](navconnect-v0.1.1...navconnect-v0.2.0)
(2026-07-29)


### Features

* Update API sources and regenerate
([#8999](#8999))
([5c36365](5c36365))
</details>

<details><summary>grafeas: 6.3.0</summary>

##
[6.3.0](grafeas-v6.2.0...grafeas-v6.3.0)
(2026-07-29)


### Features

* Update API sources and regenerate
([#8999](#8999))
([5c36365](5c36365))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pearigee pearigee pearigee approved these changes
@feywind feywind Awaiting requested review from feywind
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@quirogas quirogas

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@quirogas @pearigee