chore(firestore): silence conformance logs and fix system test concurrency - #9060
Conversation
product-auto-label
Bot
added
the
api: firestore
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes a verbose console log in the conformance runner, refactors the Firestore system test setup to retrieve the Firestore instance from the test root collection, and updates the package.json scripts to run system tests sequentially instead of concurrently. I have no feedback to provide.
| "system-test:enterprise:emulator:rest": "RUN_ENTERPRISE_TESTS=yes FIRESTORE_DATABASE_ID=firestore-enterprise FIRESTORE_EMULATOR_HOST=localhost:8080 FIRESTORE_PREFER_REST=true mocha build/system-test --timeout 1200000", | ||
| "system-test:emulator:grpc": "FIRESTORE_EMULATOR_HOST=localhost:8080 mocha build/system-test --timeout 1200000", | ||
| "system-test:enterprise:emulator:grpc": "RUN_ENTERPRISE_TESTS=yes FIRESTORE_DATABASE_ID=firestore-enterprise FIRESTORE_EMULATOR_HOST=localhost:8080 mocha build/system-test --timeout 1200000", | ||
| "system-test": "concurrently -p \"[{name}]\" -n \"grpc,rest,enterprise-grpc,enterprise-rest\" -c \"cyan,magenta,blue,yellow\" \"npm:system-test:grpc\" \"npm:system-test:rest\" \"npm:system-test:enterprise:grpc\" \"npm:system-test:enterprise:rest\"", |
There was a problem hiding this comment.
@wu-hui introduced these changes for running concurrently earlier this year. This was in response to Cloud SDK requesting reduced run time for Firestore CI. What's the reason we're reverting this change?
There was a problem hiding this comment.
I made this change because I was seeing flakey tests from deadline exceeded errors that seemingly were fixed by this. I have since made the change in system-tests/firestore.ts that may have fixed the root cause, so let me revert this and see if it's now resolved!
2 participants
Separated from #9058 to isolate Firestore CI fixes: