feat(firestore)!: complete gapic decoupling, adopt subpath imports, and remove legacy proto code (#9074) - #9074
Draft
quirogas wants to merge 9 commits into
Conversation
… imports (#8928) - Import data-plane clients via modular subpath exports to restore serverless bundle baseline - Remove obsolete admin and v1beta1 proto files and type subfolders (114k+ lines of dead code) - Pin minimum dependency version to @google-cloud/firestore-api@^0.3.0 BREAKING CHANGE: Deprecated v1beta1 client surface removed from standard exports; raw GAPIC clients separated into @google-cloud/firestore-api.
…tore-sdk-v9-decoupling
…tore-sdk-v9-decoupling # Conflicts: # handwritten/firestore/dev/src/index.ts
…tore-sdk-v9-decoupling # Conflicts: # handwritten/firestore/dev/protos/firestore_admin_v1_proto_api.js # handwritten/firestore/dev/protos/firestore_v1beta1_proto_api.js
…tore-sdk-v9-decoupling # Conflicts: # handwritten/firestore/dev/protos/firestore_admin_v1_proto_api.js # handwritten/firestore/dev/protos/firestore_v1beta1_proto_api.js
…tore-sdk-v9-decoupling
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes numerous protobuf files, updates the dependency @google-cloud/firestore-api to version ^0.3.0, and updates imports in index.ts and firestore.d.ts to point directly to the internal build paths of @google-cloud/firestore-api. The review feedback correctly identifies that deep-importing from internal directories (such as build/protos/protos and build/src/v1) is fragile and highly discouraged, recommending instead that these entry points be exposed as public subpath exports in the dependency's package configuration.
quirogas
changed the title
quirogas
changed the title
quirogas
changed the title
quirogas
changed the title
quirogas
changed the title
quirogas
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 2 of stacked disentanglement (#8928). Complete decoupling of
@google-cloud/firestorefrom embedded GAPIC client generation, transition to modular subpath imports, and remove obsolete legacy protobuf files.Summary of Changes
@google-cloud/firestore-apidependency to^0.3.0and updates internal client initialization paths to import directly from modular subpaths (@google-cloud/firestore-api/build/src/v1).v1beta1runtime files, and redundant cloned Google protobuf directories (dev/protos/google/).v1beta1Support: Dropsv1beta1re-exports in alignment with upstream generator removal.Breaking Changes
v1beta1Support: AccessingFirestore.v1beta1is deprecated and no longer supported. Consumers utilizing legacy beta client features must migrate to standardv1/ the latest official version of the library..jsproto files (dev/protos/) are removed. Applications bypassing top-level barrel exports to require private internal implementation scripts directly will encounter module resolution errors.Internal: b/531788771
📚 Stack Navigation Index