ci(workflows): add node and pnpm v7 setup to generation check - #9099
Merged
Conversation
Add Node.js 22 and pnpm v7 runtime setup steps to `.github/workflows/generation_check.yaml` prior to tool installation and generation verification. On default GitHub hosted CI runners (`ubuntu-latest`), `pnpm` is not pre-installed on the system `$PATH`. Consequently, executing `librarian install` immediately terminates with `exec: "pnpm": executable file not found in $PATH`. Explicitly configuring Node.js 22 and pnpm v7 (`pnpm/action-setup`) supplies the required Node toolchain dependencies, making the generation verification check completely self-contained and aligned with monorepo dependency conventions. For googleapis/librarian#5352
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
quirogas
marked this pull request as ready for review
August 5, 2026 21:13
Resolve modify/delete merge conflicts from workflow revert on main by restoring both generation_check.yaml and librarian_tidy.yml with required Node 22 and pnpm v7 setup steps intact.
quirogas
enabled auto-merge (squash)
August 5, 2026 21:24
shivanee-p
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Node.js 22 and pnpm v7 runtime setup steps to
.github/workflows/generation_check.yamlprior to tool installation and generation verification.On default GitHub hosted CI runners (
ubuntu-latest),pnpmis not pre-installed on the system$PATH, so executinglibrarian installimmediately fails due toexec: "pnpm": executable file not found in $PATH.For googleapis/librarian#5352