Skip to content

ci(workflows): add node and pnpm v7 setup to generation check - #9099

Merged
quirogas merged 2 commits into
googleapis:mainfrom
quirogas:fix/ci-generation-check-pnpm
Aug 6, 2026
Merged

ci(workflows): add node and pnpm v7 setup to generation check#9099
quirogas merged 2 commits into
googleapis:mainfrom
quirogas:fix/ci-generation-check-pnpm

Conversation

@quirogas

@quirogas quirogas commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Add Node.js 22 and pnpm v7 runtime setup steps to .github/workflows/generation_check.yaml prior to tool installation and generation verification.

On default GitHub hosted CI runners (ubuntu-latest), pnpm is not pre-installed on the system $PATH, so executing librarian install immediately fails due to exec: "pnpm": executable file not found in $PATH.

For googleapis/librarian#5352

Add Node.js 22 and pnpm v7 runtime setup steps to `.github/workflows/generation_check.yaml` prior to tool installation and generation verification.

On default GitHub hosted CI runners (`ubuntu-latest`), `pnpm` is not pre-installed on the system `$PATH`. Consequently, executing `librarian install` immediately terminates with `exec: "pnpm": executable file not found in $PATH`. Explicitly configuring Node.js 22 and pnpm v7 (`pnpm/action-setup`) supplies the required Node toolchain dependencies, making the generation verification check completely self-contained and aligned with monorepo dependency conventions.

For googleapis/librarian#5352
@quirogas quirogas self-assigned this Aug 5, 2026
@product-auto-label product-auto-label Bot added the api: workflows Issues related to the Workflows API. label Aug 5, 2026
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@quirogas
quirogas marked this pull request as ready for review August 5, 2026 21:13
@quirogas
quirogas requested a review from a team as a code owner August 5, 2026 21:13
Resolve modify/delete merge conflicts from workflow revert on main by restoring both generation_check.yaml and librarian_tidy.yml with required Node 22 and pnpm v7 setup steps intact.
@quirogas
quirogas enabled auto-merge (squash) August 5, 2026 21:24
@github-actions
github-actions Bot requested a review from feywind August 5, 2026 21:24
@quirogas
quirogas merged commit 6b6a239 into googleapis:main Aug 6, 2026
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: workflows Issues related to the Workflows API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants