Skip to content

chore: add protoc 33.2 - #9109

Merged
quirogas merged 1 commit into
mainfrom
addProtocToLibrarian
Aug 7, 2026
Merged

chore: add protoc 33.2#9109
quirogas merged 1 commit into
mainfrom
addProtocToLibrarian

Conversation

@sofisl

@sofisl sofisl commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

During rotation this week, I noticed that librarian did not have an explicit protoc version, and it was just grabbing my local version. This PR specifically was generated with 33.2 unknowingly: #9091.

So, I decided to set it explicitly and run generate --all. No new diffs were found.

@sofisl
sofisl requested a review from a team as a code owner August 7, 2026 17:21
@github-actions
github-actions Bot requested a review from shivanee-p August 7, 2026 17:21

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the protoc tool with version 33.2 and its SHA-256 hash to the librarian.yaml configuration. However, the specified version 33.2 does not exist, which will cause download and installation failures. It is recommended to verify and update this to a valid protoc release version.

Comment thread librarian.yaml
@quirogas
quirogas merged commit 0ad2ac3 into main Aug 7, 2026
36 checks passed
@quirogas
quirogas deleted the addProtocToLibrarian branch August 7, 2026 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants