Skip to content

fix(precise-date): support TypeScript 7 - #9115

Open
hugosmoreira wants to merge 1 commit into
googleapis:mainfrom
hugosmoreira:fix/precise-date-typescript-7
Open

fix(precise-date): support TypeScript 7#9115
hugosmoreira wants to merge 1 commit into
googleapis:mainfrom
hugosmoreira:fix/precise-date-typescript-7

Conversation

@hugosmoreira

Copy link
Copy Markdown

Fixes #9031

Summary

Remove the legacy @extends external:Date JSDoc tag from PreciseDate. The TypeScript declaration already expresses the inheritance as extends Date; TypeScript 7 treats the mismatched JSDoc target as error TS8023.

Validation

  • Confirmed unmodified main fails under TypeScript 7.0.2 with the reported TS8023 error
  • Compiled the package successfully with TypeScript 5.8 and TypeScript 7.0.2 after the change
  • Compiled a TypeScript 7.0.2 consumer against the emitted declaration
  • Ran all 51 package tests successfully
  • Ran the Google TypeScript Style ESLint configuration successfully
  • Confirmed code coverage does not decrease
  • Updated the affected documentation comment

@hugosmoreira
hugosmoreira requested a review from a team as a code owner August 8, 2026 01:16
@github-actions
github-actions Bot requested a review from shivanee-p August 8, 2026 01:16

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the @extends external:Date JSDoc annotation from the class documentation in core/precise-date/src/index.ts. There are no review comments, and I have no feedback to provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@google-cloud/precise-date not compatible with TypeScript 7

1 participant