fix(storage): resolve strict linter and TypeScript errors - #9198
Merged
Dhriti07 merged 8 commits intoAug 25, 2026
Conversation
…orts for improved type safety and code cleanliness
…, and refactor test to use async/await
product-auto-label
Bot
added
the
api: storage
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors imports, formatting, and promise handling across several files, and updates tsconfig.json to include more test paths. However, several changes to promise chains (specifically refactoring .then(..., callback) to .then(...).catch(callback) or adding .catch() handlers) introduce critical bugs where callbacks can be invoked twice if the success callback throws an error. These issues affect getProjectId in service.ts, prepareRequest in util.ts, and createURI / createURIAsync in resumable-upload.ts.
…ting promise issues
Dhriti07
reviewed
Aug 24, 2026
Dhriti07
reviewed
Aug 24, 2026
kalragauri
approved these changes
Aug 25, 2026
Dhriti07
approved these changes
Aug 25, 2026
… extract upload logic to a private method
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕