chore(proto-plus): update Python version and clean up enums.py#16912
Draft
chalmerlowe wants to merge 4 commits intomainfrom
Draft
chore(proto-plus): update Python version and clean up enums.py#16912chalmerlowe wants to merge 4 commits intomainfrom
chalmerlowe wants to merge 4 commits intomainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request replaces a descriptive comment in packages/proto-plus/proto/enums.py with a TODO referencing Issue #16911 regarding the use of the ignore attribute. I have no feedback to provide as there are no review comments.
Contributor
|
Switching to draft until presubmits are green |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates
proto-plusto establish Python 3.10 as the minimum supported version, dropping support for Python 3.9 and below.Changes
pyproject.tomlandnoxfile.pyto require Python 3.10+ and remove references to Python 3.9.repeated.pyto use the walrus operator (PEP 572).Documentation: Updated a traceback example in
docs/fields.rstto reference Python 3.10.Blocking
This PR is blocked by PR #16910