chore(versions): update Python version support to 3.10+ in gapic-generator#16910
chore(versions): update Python version support to 3.10+ in gapic-generator#16910chalmerlowe wants to merge 21 commits intomainfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request removes support for Python 3.7 across the repository, updating documentation, CI scripts, and generator templates to reflect a minimum requirement of Python 3.8. Feedback was provided to ensure consistency between CI scripts by including Python 3.13 in the list of supported versions within the comments of ci/run_conditional_tests.sh.
| # `TEST_TYPE` should be one of ["docs", "docfx", "prerelease", "unit"] | ||
| # or match the name of the nox session that you want to run. | ||
| # `PY_VERSION` should be one of ["3.7", "3.8", "3.9", "3.10", "3.11", "3.12"] | ||
| # `PY_VERSION` should be one of ["3.8", "3.9", "3.10", "3.11", "3.12"] |
There was a problem hiding this comment.
The list of supported Python versions in this comment is inconsistent with ci/run_single_test.sh, which includes 3.13. Since you are updating this line to reflect the new supported versions, please include 3.13 here as well to maintain consistency across CI scripts.
| # `PY_VERSION` should be one of ["3.8", "3.9", "3.10", "3.11", "3.12"] | |
| # PY_VERSION should be one of ["3.8", "3.9", "3.10", "3.11", "3.12", "3.13"] |
References
- Changes to shared configurations or documentation of supported versions should be applied consistently across all relevant scripts to avoid confusion and maintenance issues.
| .. code-block:: shell | ||
| $ virtualenv ~/.local/client-lib --python=`which python3.7` | ||
| $ virtualenv ~/.local/client-lib --python=`which python3.8` |
There was a problem hiding this comment.
nit: We can use venv instead of virtualenv. We can also bump this to the latest version 3.14
…ioned __init__.py.j2
a73f347 to
9a6dece
Compare
c78a787 to
9ae1839
Compare
Note
This [gapic-generator] PR is presented for discussion. Based on preliminary feedback, we will proceed to update it from removing only 3.7 to also removing 3.8 and 3.9.
This PR blocks multiple other PRs which are presented for discussion and preliminary review. Those PRs leapfrog directly to 3.10 as an experiment. None of them will be merged until this PR fully removes 3.10.
Overview
This Pull Request updates the gapic-generator package and related CI configurations to reflect the deprecation of Python 3.7. It updates documentation, templates, and CI scripts to establish Python 3.8 as the new minimum supported version where applicable.
Changes
Documentation:
Templates:
CI Configurations:
Post-Processing Configurations:
Reasoning
Python 3.7 has reached End-of-Life (EOL) and is no longer supported. These changes ensure that our generator and the libraries it produces align with current support policies and reduce maintenance burden by removing dead code paths.
Fixes internal issue: http://b/482126936 🦕