Skip to content

chore(sqlalchemy-spanner): update Python version to 3.10 #16913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
chalmerlowe wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −7
Draft

chore(sqlalchemy-spanner): update Python version to 3.10 #16913

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8203ef9
chore(sqlalchemy-spanner): update Python version in setup.py to 3.10
chalmerlowe May 1, 2026
d9dc884
chore(sqlalchemy-spanner): update Python version in noxfile.py to 3.10
chalmerlowe May 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions packages/sqlalchemy-spanner/noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,11 +80,10 @@ class = StreamHandler
BLACK_VERSION = "black==23.7.0"
ISORT_VERSION = "isort==5.11.0"
BLACK_PATHS = ["google", "tests", "noxfile.py", "setup.py", "samples"]
UNIT_TEST_PYTHON_VERSIONS = ["3.8", "3.9", "3.10", "3.11", "3.12", "3.13", "3.14"]
UNIT_TEST_PYTHON_VERSIONS = ["3.10", "3.11", "3.12", "3.13", "3.14"]
ALL_PYTHON = list(UNIT_TEST_PYTHON_VERSIONS)
ALL_PYTHON.extend(["3.7"])
SYSTEM_TEST_PYTHON_VERSIONS = ["3.12"]
SYSTEM_COMPLIANCE_MIGRATION_TEST_PYTHON_VERSIONS = ["3.8", "3.12", "3.14"]
SYSTEM_COMPLIANCE_MIGRATION_TEST_PYTHON_VERSIONS = ["3.12", "3.14"]
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Changes to shared configurations, like Python version lists in noxfiles, should be applied consistently across all relevant packages in a dedicated, universal change rather than piecemeal in individual pull requests.

References
  1. Changes to shared configurations should be applied consistently across all relevant packages in a dedicated, universal change.

DEFAULT_PYTHON_VERSION = "3.14"
DEFAULT_PYTHON_VERSION_FOR_SQLALCHEMY_20 = "3.14"

Expand Down Expand Up @@ -318,8 +317,6 @@ def _migration_test(session):
@nox.parametrize("test_type", ["unit", "mockserver"])
def unit(session, test_type):
"""Run unit tests."""
if session.python in ("3.7",):
session.skip("Python 3.7 is no longer supported")

if (
test_type == "mockserver"
Expand Down
3 changes: 1 addition & 2 deletions packages/sqlalchemy-spanner/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,11 +58,10 @@
author="Google LLC",
author_email="googleapis-packages@google.com",
license="Apache 2.0",
python_requires=">=3.10",
classifiers=[
"Intended Audience :: Developers",
"License :: OSI Approved :: Apache Software License",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
Comment on lines 65 to 67
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Changes to shared configurations, such as supported Python version classifiers, should be applied consistently across all relevant packages in a dedicated, universal change rather than piecemeal in individual pull requests.

Suggested change
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
"Programming Language :: Python :: 3.13",
"Programming Language :: Python :: 3.14",
References
  1. Changes to shared configurations should be applied consistently across all relevant packages in a dedicated, universal change.

Expand Down
Loading