chore(sqlalchemy-spanner): update Python version to 3.10#16913
chore(sqlalchemy-spanner): update Python version to 3.10#16913chalmerlowe wants to merge 2 commits intomainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes support for Python 3.7, 3.8, and 3.9 from the noxfile.py and setup.py configurations, while updating the minimum required version to 3.10. The reviewer noted that modifications to shared configurations should ideally be handled through universal updates across all packages rather than piecemeal. Additionally, a suggestion was made to include Python 3.13 and 3.14 in the setup.py classifiers to ensure consistency with the versions defined in the test suite.
| ALL_PYTHON.extend(["3.7"]) | ||
| SYSTEM_TEST_PYTHON_VERSIONS = ["3.12"] | ||
| SYSTEM_COMPLIANCE_MIGRATION_TEST_PYTHON_VERSIONS = ["3.8", "3.12", "3.14"] | ||
| SYSTEM_COMPLIANCE_MIGRATION_TEST_PYTHON_VERSIONS = ["3.12", "3.14"] |
There was a problem hiding this comment.
Changes to shared configurations, like Python version lists in noxfiles, should be applied consistently across all relevant packages in a dedicated, universal change rather than piecemeal in individual pull requests.
References
- Changes to shared configurations should be applied consistently across all relevant packages in a dedicated, universal change.
| "Programming Language :: Python :: 3.10", | ||
| "Programming Language :: Python :: 3.11", | ||
| "Programming Language :: Python :: 3.12", |
There was a problem hiding this comment.
Changes to shared configurations, such as supported Python version classifiers, should be applied consistently across all relevant packages in a dedicated, universal change rather than piecemeal in individual pull requests.
| "Programming Language :: Python :: 3.10", | |
| "Programming Language :: Python :: 3.11", | |
| "Programming Language :: Python :: 3.12", | |
| "Programming Language :: Python :: 3.10", | |
| "Programming Language :: Python :: 3.11", | |
| "Programming Language :: Python :: 3.12", | |
| "Programming Language :: Python :: 3.13", | |
| "Programming Language :: Python :: 3.14", |
References
- Changes to shared configurations should be applied consistently across all relevant packages in a dedicated, universal change.
|
Switching to draft until presubmits are green |
2 participants
This PR updates
sqlalchemy-spannerto establish Python 3.10 as the minimum supported version, dropping support for Python 3.9 and below.Changes
setup.pyandnoxfile.pyto require Python 3.10+ and remove references to Python 3.7, 3.8, and 3.9.noxfile.pythat was skipping Python 3.7.Blocking
This PR is blocked by PR #16910