feat(memorystore): enable gRPC transport#16927
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces gRPC and gRPC AsyncIO transport support for the Memorystore client, including the necessary infrastructure, pagers, and generated samples. The reviewer identified a potential security risk regarding the hardcoded gRPC message length limits, which are set to -1 (unlimited) in the new transport implementations, potentially exposing the service to denial-of-service attacks via memory exhaustion.
| options=[ | ||
| ("grpc.max_send_message_length", -1), | ||
| ("grpc.max_receive_message_length", -1), | ||
| ], |
There was a problem hiding this comment.
Hardcoding gRPC message length limits to -1 (unlimited) can pose a security risk by allowing excessively large messages to consume memory, potentially leading to OOM errors. Consider setting a reasonable upper bound based on expected payload sizes.
| scopes (Optional[Sequence[str]]): A optional list of scopes needed for this | ||
| service. These are only used when credentials are not specified and | ||
| are passed to :func:`google.auth.default`. | ||
| channel (Optional[Union[aio.Channel, Callable[..., aio.Channel]]]): |
There was a problem hiding this comment.
Hardcoding gRPC message length limits to -1 (unlimited) can pose a security risk by allowing excessively large messages to consume memory, potentially leading to OOM errors. Consider setting a reasonable upper bound based on expected payload sizes.
| options=[ | ||
| ("grpc.max_send_message_length", -1), | ||
| ("grpc.max_receive_message_length", -1), | ||
| ], |
There was a problem hiding this comment.
Hardcoding gRPC message length limits to -1 (unlimited) can pose a security risk by allowing excessively large messages to consume memory, potentially leading to OOM errors. Consider setting a reasonable upper bound based on expected payload sizes.
| scopes (Optional[Sequence[str]]): A optional list of scopes needed for this | ||
| service. These are only used when credentials are not specified and | ||
| are passed to :func:`google.auth.default`. | ||
| channel (Optional[Union[aio.Channel, Callable[..., aio.Channel]]]): |
There was a problem hiding this comment.
Hardcoding gRPC message length limits to -1 (unlimited) can pose a security risk by allowing excessively large messages to consume memory, potentially leading to OOM errors. Consider setting a reasonable upper bound based on expected payload sizes.
2 participants
Updates
librarianversion tov0.12.0and regenerates all clients.This tag picked up a change to the
memorystoreconfiguration to enablegrpcas a client transport, the changes for which are included in this update.These were the only changes produced by
generate --all.