fix(pubsub) : resolve issue with pubsub generation#17219
Merged
Conversation
…st-processing configurations
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the supported Python versions for the google-cloud-pubsub library, dropping support for Python 3.9 and adding explicit compatibility for Python 3.14. It also corrects a formatting error in setup.py where dependency lines were merged and adds a warning filter to pytest.ini. Feedback identifies significant issues in the post-processing YAML configuration, specifically regarding a trailing newline bug that could break setup.py generation, the use of hardcoded versions instead of regex backreferences, and the removal of a relevant issue link.
suztomo
approved these changes
May 21, 2026
| apis: | ||
| - path: google/pubsub/v1 | ||
| skip_generate: true | ||
| skip_generate: false |
Member
There was a problem hiding this comment.
Can you remove this line. The default is false. Conciseness is good.
chalmerlowe
commented
May 21, 2026
parthea
requested changes
May 21, 2026
parthea
approved these changes
May 22, 2026
chalmerlowe
changed the title
chalmerlowe
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrects issue with package generation.
Changes
librarian.yaml:
google-cloud-pubsubby removingskip_generate..librarian/generator-input/client-post-processing/pubsub-integration.yaml:
grpcio-statuspost-processing rules that are no longer necessary.grpciodependency constraint back into two separate, version-constrained lines for use insetup.py.packages/google-cloud-pubsub/pytest.ini:
(ignore:.*SelectableGroups dict interface is deprecated:DeprecationWarning)to preventpytestfrom failing on third-party dependency deprecation warnings under Python 3.11+.packages/google-cloud-pubsub/README.rst & packages/google-cloud-pubsub/docs/README.rst:
READMEfiles updated due to changes in synthtool template now reflect the dropped support for Python 3.9 (minimum version bounds bumped from >= 3.9 to >= 3.10).