Skip to content

fix(pubsub) : resolve issue with pubsub generation #17219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
parthea merged 3 commits into from
May 22, 2026
Merged

fix(pubsub) : resolve issue with pubsub generation #17219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
efdecaf
chore(pubsub): import optimized configuration for clean-room verifica…
chalmerlowe May 21, 2026
aa887e5
feat(pubsub): regenerate library cleanly from main using optimized po…
chalmerlowe May 21, 2026
8dd2a43
Apply suggestion from @chalmerlowe
chalmerlowe May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 4 additions & 12 deletions .librarian/generator-input/client-post-processing/pubsub-integration.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,14 +369,6 @@ replacements:
count: 1


# --- FIX: Restore pubsub-specific grpcio bound ---
- paths:
- "packages/google-cloud-pubsub/setup.py"
before: '([ \t]+)"grpcio >= [0-9\.]+, < 2\.0\.0",\n'
after: |-
\g<1>"grpcio >= 1.51.3, < 2.0.0; python_version < '3.14'", # https://github.com/googleapis/python-pubsub/issues/609
count: 1

# --- FIX: Restore missing dependencies, extras, and url dynamically ---
- paths:
- "packages/google-cloud-pubsub/setup.py"
Expand Down Expand Up @@ -530,8 +522,8 @@ replacements:

- paths:
- "packages/google-cloud-pubsub/setup.py"
before: '"grpcio-status >= 1\.44\.0",'
after: '"grpcio-status >= 1.51.3",'
before: '([ \t]+)"grpcio >= [0-9\.]+, < 2\.0\.0",\n(?:[ \t]*)"grpcio >= 1\.75\.1, < 2\.0\.0; python_version >= ''3\.14''",\n'
after: |-
\g<1>"grpcio >= 1.51.3, < 2.0.0; python_version < '3.14'",
\g<1>"grpcio >= 1.75.1, < 2.0.0; python_version >= '3.14'",
Comment thread
chalmerlowe marked this conversation as resolved.
count: 1


1 change: 0 additions & 1 deletion librarian.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1659,7 +1659,6 @@ libraries:
version: 2.38.0
apis:
- path: google/pubsub/v1
skip_generate: true
python:
library_type: GAPIC_COMBO
opt_args_by_api:
Expand Down
5 changes: 3 additions & 2 deletions packages/google-cloud-pubsub/README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,14 +62,15 @@ Supported Python Versions
Our client libraries are compatible with all current `active`_ and `maintenance`_ versions of
Python.

Python >= 3.9, including 3.14
Python >= 3.10, including 3.14
Comment thread
parthea marked this conversation as resolved.

.. _active: https://devguide.python.org/devcycle/#in-development-main-branch
.. _maintenance: https://devguide.python.org/devcycle/#maintenance-branches

Unsupported Python Versions
^^^^^^^^^^^^^^^^^^^^^^^^^^^
Python <= 3.8
Python <= 3.9


If you are using an `end-of-life`_
version of Python, we recommend that you update as soon as possible to an actively supported version.
Expand Down
5 changes: 3 additions & 2 deletions packages/google-cloud-pubsub/docs/README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,14 +62,15 @@ Supported Python Versions
Our client libraries are compatible with all current `active`_ and `maintenance`_ versions of
Python.

Python >= 3.9, including 3.14
Python >= 3.10, including 3.14

.. _active: https://devguide.python.org/devcycle/#in-development-main-branch
.. _maintenance: https://devguide.python.org/devcycle/#maintenance-branches

Unsupported Python Versions
^^^^^^^^^^^^^^^^^^^^^^^^^^^
Python <= 3.8
Python <= 3.9


If you are using an `end-of-life`_
version of Python, we recommend that you update as soon as possible to an actively supported version.
Expand Down
3 changes: 3 additions & 0 deletions packages/google-cloud-pubsub/pytest.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,3 +26,6 @@ filterwarnings =
ignore:You are using a non-supported Python version \(([\d\.]+)\)\. Google will not post any further updates to google\.api_core.*:FutureWarning
# These google library EOL warnings for Python versions don't matter for the purposes of a test.
ignore::FutureWarning:google.*:
# Suppress SelectableGroups deprecation warning from older dependencies under Python 3.11+
ignore:.*SelectableGroups dict interface is deprecated:DeprecationWarning

3 changes: 2 additions & 1 deletion packages/google-cloud-pubsub/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,8 @@
# Exclude incompatible versions of `google-auth`
# See https://github.com/googleapis/google-cloud-python/issues/12364
"google-auth >= 2.14.1, <3.0.0,!=2.24.0,!=2.25.0",
"grpcio >= 1.51.3, < 2.0.0; python_version < '3.14'", # https://github.com/googleapis/python-pubsub/issues/609 "grpcio >= 1.75.1, < 2.0.0; python_version >= '3.14'",
"grpcio >= 1.51.3, < 2.0.0; python_version < '3.14'",
"grpcio >= 1.75.1, < 2.0.0; python_version >= '3.14'",
"proto-plus >= 1.22.3, <2.0.0",
"proto-plus >= 1.25.0, <2.0.0; python_version >= '3.13'",
"protobuf >= 4.25.8, < 8.0.0",
Expand Down
Loading