fix(firestore): BulkWriter pop from an empty deque - #17490
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a safety check to _schedule_ready_retries in bulk_writer.py to prevent popping from an empty _retries queue. The reviewer suggested a performance improvement to break out of the loop early when the queue is empty, rather than checking the condition on every iteration.
…_writer.py Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
daniel-sanche
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
daniel-sanche
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
chalmerlowe
approved these changes
Jul 24, 2026
chalmerlowe
left a comment
chalmerlowe
left a comment
Contributor
There was a problem hiding this comment.
Left a #QUESTION/#NIT.
Leaving it up to your discretion.
Approving regardless.
| ) | ||
|
|
||
| for _ in range(take_until_index): | ||
| if not self._retries: |
Contributor
There was a problem hiding this comment.
I see that cover still passes.
#QUESTION
#NIT
Is this conditional something that should be tested to ensure we don't have regression if this code ever changes?
I will approve and defer to you in determining whether adding at test is necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some situations, the BulkWriter would attempt to pop a retry config from an empty deque. This PR adds a safeguard to end immediately if the list is empty
Fixes #16138