chore(bigquery): add dynamic logging banner to nox mypy session - #17492
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a log_package_context context manager in noxfile.py to log a package context banner upon Nox session completion, applying it to the mypy session. The feedback suggests replacing os.getcwd() with pathlib.Path(file).parent.name to ensure the package name is correctly resolved even when Nox is executed from outside the package directory.
chalmerlowe
force-pushed
the
feat/bigquery-mypy-banner
branch
9 times, most recently
from
June 18, 2026 14:44
fb9bf56 to
042e991
Compare
parthea
reviewed
Jun 19, 2026
Contributor
There was a problem hiding this comment.
Could we handle this globally in run_conditional_tests.sh?
If we print the banner right after the test script completes, it will output right next to the Nox final exit summary. This gives us instant coverage for all packages and all sessions with a 1-2 lines of bash code.
https://github.com/googleapis/google-cloud-python/compare/main...testing-ci?quick_pull=1
parthea
approved these changes
Jun 19, 2026
chalmerlowe
added a commit
that referenced
this pull request
Jun 25, 2026
This PR adds a dynamic logging banner `Finished session for <package>` to nox `mypy` sessions in `bigquery` to simplify troubleshooting. Currently when a nox session runs, there may be many lines of text between a reference to which package is being tested and the result summary line. This can make it more difficult to determine which package is affected without a lot of manual scrolling (every time you need to trouble shoot an issue). This is especially true if you use `Ctrl+F` to zoom over to summaries with words like `failed`. ``` change detected in packages/bigframes/ [many lines of text...] 2547 passed, 157 skipped, 9 xfailed, 1 xpassed, 586 warnings in 136.68s (0:02:16) nox > Session unit-3.11(test_extra=True) failed in 3 minutes. ``` The PR adds a banner line right before the nox result summary: ``` change detected in packages/bigframes/ [many lines of text...] 2547 passed, 157 skipped, 9 xfailed, 1 xpassed, 586 warnings in 136.68s (0:02:16) nox > Finished session for bigframes # NEW LINE, right before the summary line nox > Session unit-3.11(test_extra=True) failed in 3 minutes. ``` > [!note] > There is no convenient way to inject a log line into the nox session and have it print **exactly** where you want. Also, because the long term intent is to add this to all nox sessions I included an easy to apply `contextmanager` to ensure the correct placement of the new logging banner. > [!note] > This PR only adds this capability to a single nox session (`mypy`) and a single handwritten package (`bigquery`). I did not want to invest a lot of time unless the team feels it is beneficial. In which case, we can add a task the next sprint to make this a global change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a dynamic logging banner
Finished session for <package>to nox
mypysessions inbigqueryto simplify troubleshooting.Currently when a nox session runs, there may be many lines of text between a reference to which package is being tested and the result summary line. This can make it more difficult to determine which package is affected without a lot of manual scrolling (every time you need to trouble shoot an issue). This is especially true if you use
Ctrl+Fto zoom over to summaries with words likefailed.The PR adds a banner line right before the nox result summary:
Note
There is no convenient way to inject a log line into the nox session and have it print exactly where you want. Also, because the long term intent is to add this to all nox sessions I included an easy to apply
contextmanagerto ensure the correct placement of the new logging banner.Note
This PR only adds this capability to a single nox session (
mypy) and a single handwritten package (bigquery). I did not want to invest a lot of time unless the team feels it is beneficial. In which case, we can add a task the next sprint to make this a global change.