feat: bump gapic-generator to v1.38.0 and update post-processing scripts - #18057
feat: bump gapic-generator to v1.38.0 and update post-processing scripts#18057hebaalazzeh wants to merge 13 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the gapic-generator tool version to 1.38.0 and bumps the minimum google-api-core dependency version to 2.28.0 across multiple client post-processing configurations. It also cleans up several obsolete temporary post-processing patches. Regarding the feedback, there is an issue in datastore-integration.yaml where including .. include:: README.rst in the replacement block will cause duplicate content in the generated documentation.
| after: | | ||
| .. include:: README.rst | ||
|
|
||
| .. note:: |
There was a problem hiding this comment.
The before pattern matches starting from .. include:: multiprocessing.rst. Since .. include:: README.rst precedes this line in the generated index.rst file, it is not matched and will be preserved at the top of the file. Including .. include:: README.rst in the after block will therefore cause it to be duplicated in the final output. Removing it from the after block will prevent this duplication.
after: |
.. note::
quirogas
left a comment
quirogas
left a comment
There was a problem hiding this comment.
The changes to librarian.yaml look good to me. Let's wait for the generation tests to pass before merging this portion of the PR, though.
quirogas
added
the
do not merge
af499c8 to
779d0b9
Compare
…y-storage and bigtable
…erated bigtable_v2
779d0b9 to
febd1ef
Compare
2 participants
Description
gapic-generatorversion to1.38.0inlibrarian.yaml..librarian/generator-input/client-post-processing/(bigquery-storage,bigtable,datastore,firestore,logging, andspanner) to handle generator template changes:docs/index.rstreplacement patterns for multi-version libraries (bigquery-storage,bigtable,datastore).import syscleanup infirestoreandlogging.spanner(now natively emitted by gapic-generator 1.38).Note: The repo-wide regeneration diff is stacked on top of this PR in a separate PR.