Skip to content

feat(auth): add deprecation warning for grpcio < 1.83.0 (PQC support) - #18070

Merged
parthea merged 1 commit into
mainfrom
feat/auth-pqc-deprecation-warning
Aug 12, 2026
Merged

feat(auth): add deprecation warning for grpcio < 1.83.0 (PQC support)#18070
parthea merged 1 commit into
mainfrom
feat/auth-pqc-deprecation-warning

Conversation

@ohmayr

@ohmayr ohmayr commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Emits a deprecation FutureWarning when google.auth.transport.grpc is imported with grpcio < 1.83.0.
In October 2026, Google Cloud client libraries (including google-auth) will raise minimum requirements to enforce grpcio >= 1.83.0 for Post-Quantum Cryptography (PQC) support.

Towards: b/537446703

@ohmayr
ohmayr requested review from a team as code owners August 11, 2026 18:28

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a deprecation warning for grpcio versions older than 1.83.0 to prepare for the migration to Post-Quantum Cryptography (PQC). The review feedback identifies an issue with the version parsing logic, which incorrectly handles pre-release versions (such as '1.83.1rc1') and shorter version strings (such as '1.83'), causing them to trigger the deprecation warning erroneously. A robust parsing implementation is suggested to resolve this issue.

Comment thread packages/google-auth/google/auth/transport/grpc.py

@daniel-sanche daniel-sanche left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ohmayr ohmayr added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Aug 11, 2026
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 12, 2026
@parthea
parthea merged commit 68bdaba into main Aug 12, 2026
52 checks passed
@parthea
parthea deleted the feat/auth-pqc-deprecation-warning branch August 12, 2026 15:05
hebaalazzeh pushed a commit that referenced this pull request Aug 13, 2026
…#18070)

Emits a deprecation `FutureWarning` when `google.auth.transport.grpc` is
imported with `grpcio < 1.83.0`.
In October 2026, Google Cloud client libraries (including `google-auth`)
will raise minimum requirements to enforce `grpcio >= 1.83.0` for
Post-Quantum Cryptography (PQC) support.

Towards: b/537446703
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants