fix(bigframes): resolve session-scoped API method logging by shuoweil · Pull Request #18076 · googleapis/google-cloud-python

shuoweil · 2026-08-11T19:29:14Z

Fixes an issue where API method calls on DataFrame and Series objects were recorded into global state instead of their specific session, preventing cross-session and cross-test logging interference.

Updated log_adapter._find_session to detect active sessions directly from DataFrame and Series instances.
Added recursion safeguards during session property lookup in log_adapter.

Fixes #<545233537> 🦕

gemini-code-assist

Code Review

This pull request refactors the session resolution logic in log_adapter.py to search through all positional arguments for a Session instance or objects containing a _session or session attribute. It also updates the unit tests in test_io_bigquery.py to use explicit mock sessions and log adapter calls instead of relying on DataFrame operations. The review feedback suggests refactoring the session attribute lookup in _find_session to eliminate duplicated code by iterating over a tuple of attribute names.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

…sion lookup

sycai · 2026-08-11T21:06:40Z

+    for arg in args:
+        if isinstance(arg, Session) and _is_session_initialized(arg):
+            return arg
+        if hasattr(arg, "__dict__") and "_block" in arg.__dict__:
+            session = getattr(arg, "_session", None)
+            if isinstance(session, Session) and _is_session_initialized(session):
+                return session
+


Should be place this before the kwargs check to preserve the original checking sequence?

Good point! Reordered _find_session to check args before kwargs, preserving the original sequence.

🤖 I have created a release *beep* *boop* --- ## [2.48.0](bigframes-v2.47.0...bigframes-v2.48.0) (2026-08-12) ### Features * **bigframes:** Transpiler supports more string ops ([#17693](#17693)) ([7d2bc21](7d2bc21)) ### Bug Fixes * **bigframes:** fix field name typos for ai.generate* functions ([#17983](#17983)) ([1b5c48b](1b5c48b)) * **bigframes:** resolve session-scoped API method logging ([#18076](#18076)) ([ace618b](ace618b)) * **bigframes:** update GeminiTextGenerator default model to gemini-2.5-flash ([#18060](#18060)) ([5770ff6](5770ff6)) * bump @angular/compiler, @angular/common, @angular/core, @angular/forms, @angular/platform-browser, @angular/router and @angular/compiler-cli in /packages/bigframes/bigframes/display/table_widget_angular ([#17992](#17992)) ([346aaab](346aaab)) * bump fast-uri from 3.1.4 to 3.1.5 in /packages/bigframes/bigframes/display/table_widget_angular ([#17989](#17989)) ([3b3f3f4](3b3f3f4)) * bump hono from 4.12.31 to 4.13.1 in /packages/bigframes/bigframes/display/table_widget_angular ([#18032](#18032)) ([cddf35b](cddf35b)) * bump ip-address and express-rate-limit in /packages/bigframes/bigframes/display/table_widget_angular ([#17985](#17985)) ([02ed656](02ed656)) * bump undici and @angular/build in /packages/bigframes/bigframes/display/table_widget_angular ([#17986](#17986)) ([6938061](6938061)) * bump undici from 7.25.0 to 7.29.0 in /packages/bigframes/tests/js ([#17987](#17987)) ([65a3571](65a3571)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

🤖 I have created a release *beep* *boop* --- ## [2.48.0](googleapis/google-cloud-python@bigframes-v2.47.0...bigframes-v2.48.0) (2026-08-12) ### Features * **bigframes:** Transpiler supports more string ops ([#17693](googleapis/google-cloud-python#17693)) ([7d2bc21](googleapis/google-cloud-python@7d2bc21)) ### Bug Fixes * **bigframes:** fix field name typos for ai.generate* functions ([#17983](googleapis/google-cloud-python#17983)) ([1b5c48b](googleapis/google-cloud-python@1b5c48b)) * **bigframes:** resolve session-scoped API method logging ([#18076](googleapis/google-cloud-python#18076)) ([ace618b](googleapis/google-cloud-python@ace618b)) * **bigframes:** update GeminiTextGenerator default model to gemini-2.5-flash ([#18060](googleapis/google-cloud-python#18060)) ([5770ff6](googleapis/google-cloud-python@5770ff6)) * bump @angular/compiler, @angular/common, @angular/core, @angular/forms, @angular/platform-browser, @angular/router and @angular/compiler-cli in /packages/bigframes/bigframes/display/table_widget_angular ([#17992](googleapis/google-cloud-python#17992)) ([346aaab](googleapis/google-cloud-python@346aaab)) * bump fast-uri from 3.1.4 to 3.1.5 in /packages/bigframes/bigframes/display/table_widget_angular ([#17989](googleapis/google-cloud-python#17989)) ([3b3f3f4](googleapis/google-cloud-python@3b3f3f4)) * bump hono from 4.12.31 to 4.13.1 in /packages/bigframes/bigframes/display/table_widget_angular ([#18032](googleapis/google-cloud-python#18032)) ([cddf35b](googleapis/google-cloud-python@cddf35b)) * bump ip-address and express-rate-limit in /packages/bigframes/bigframes/display/table_widget_angular ([#17985](googleapis/google-cloud-python#17985)) ([02ed656](googleapis/google-cloud-python@02ed656)) * bump undici and @angular/build in /packages/bigframes/bigframes/display/table_widget_angular ([#17986](googleapis/google-cloud-python#17986)) ([6938061](googleapis/google-cloud-python@6938061)) * bump undici from 7.25.0 to 7.29.0 in /packages/bigframes/tests/js ([#17987](googleapis/google-cloud-python#17987)) ([65a3571](googleapis/google-cloud-python@65a3571)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> GitOrigin-RevId: 102c940183ac1cf5670b46c17a47f559926634de Change-Id: Ia15429511df3ebed77f5b4ad45779f8c6be0316d

Fixes an issue where API method calls on DataFrame and Series objects were recorded into global state instead of their specific session, preventing cross-session and cross-test logging interference. - Updated `log_adapter._find_session` to detect active sessions directly from DataFrame and Series instances. - Added recursion safeguards during session property lookup in `log_adapter`. Fixes #<545233537> 🦕 --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

🤖 I have created a release *beep* *boop* --- ## [2.48.0](bigframes-v2.47.0...bigframes-v2.48.0) (2026-08-12) ### Features * **bigframes:** Transpiler supports more string ops ([#17693](#17693)) ([7d2bc21](7d2bc21)) ### Bug Fixes * **bigframes:** fix field name typos for ai.generate* functions ([#17983](#17983)) ([1b5c48b](1b5c48b)) * **bigframes:** resolve session-scoped API method logging ([#18076](#18076)) ([ace618b](ace618b)) * **bigframes:** update GeminiTextGenerator default model to gemini-2.5-flash ([#18060](#18060)) ([5770ff6](5770ff6)) * bump @angular/compiler, @angular/common, @angular/core, @angular/forms, @angular/platform-browser, @angular/router and @angular/compiler-cli in /packages/bigframes/bigframes/display/table_widget_angular ([#17992](#17992)) ([346aaab](346aaab)) * bump fast-uri from 3.1.4 to 3.1.5 in /packages/bigframes/bigframes/display/table_widget_angular ([#17989](#17989)) ([3b3f3f4](3b3f3f4)) * bump hono from 4.12.31 to 4.13.1 in /packages/bigframes/bigframes/display/table_widget_angular ([#18032](#18032)) ([cddf35b](cddf35b)) * bump ip-address and express-rate-limit in /packages/bigframes/bigframes/display/table_widget_angular ([#17985](#17985)) ([02ed656](02ed656)) * bump undici and @angular/build in /packages/bigframes/bigframes/display/table_widget_angular ([#17986](#17986)) ([6938061](6938061)) * bump undici from 7.25.0 to 7.29.0 in /packages/bigframes/tests/js ([#17987](#17987)) ([65a3571](65a3571)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

shuoweil requested review from sycai and tswast August 11, 2026 19:29

shuoweil self-assigned this Aug 11, 2026

shuoweil requested review from a team as code owners August 11, 2026 19:29

gemini-code-assist Bot reviewed Aug 11, 2026

View reviewed changes

Comment thread packages/bigframes/bigframes/core/logging/log_adapter.py Outdated

fix(bigframes): resolve session-scoped api logging in log_adapter

74e2ba2

shuoweil force-pushed the shuowei-fix-session-logging-and-labels branch from 0f0d41f to 74e2ba2 Compare August 11, 2026 19:32

shuoweil marked this pull request as draft August 11, 2026 19:32

Update packages/bigframes/bigframes/core/logging/log_adapter.py

108530f

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

shuoweil marked this pull request as ready for review August 11, 2026 19:36

shuoweil changed the title ~~fix: resolve session-scoped api logging and stabilize label trimming tests~~ fix: resolve session-scoped API method logging Aug 11, 2026

shuoweil added 2 commits August 11, 2026 19:41

fix(bigframes): prevent recursion during session lookup in log_adapter

ca9a89c

fix(bigframes): prevent uninitialized object getattr recursion in ses…

bc504ee

…sion lookup

daniel-sanche changed the title ~~fix: resolve session-scoped API method logging~~ fix(bigframes): resolve session-scoped API method logging Aug 11, 2026

Merge branch 'main' into shuowei-fix-session-logging-and-labels

55e132a

sycai reviewed Aug 11, 2026

View reviewed changes

fix(bigframes): check args before kwargs in _find_session

efccfdd

sycai approved these changes Aug 11, 2026

View reviewed changes

shuoweil enabled auto-merge (squash) August 11, 2026 22:31

shuoweil added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 11, 2026

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 11, 2026

shuoweil added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 12, 2026

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 12, 2026

shuoweil merged commit ace618b into main Aug 12, 2026
52 checks passed

shuoweil deleted the shuowei-fix-session-logging-and-labels branch August 12, 2026 15:19

release-please Bot mentioned this pull request Aug 12, 2026

chore(main): release bigframes 2.48.0 #17982

Merged

Navigation Menu

Uh oh!

fix(bigframes): resolve session-scoped API method logging - #18076

fix(bigframes): resolve session-scoped API method logging#18076
shuoweil merged 6 commits into
mainfrom
shuowei-fix-session-logging-and-labels

shuoweil commented Aug 11, 2026 •

edited

Loading

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

sycai Aug 11, 2026

Uh oh!

shuoweil Aug 11, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

shuoweil commented Aug 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

sycai Aug 11, 2026

Choose a reason for hiding this comment

Uh oh!

shuoweil Aug 11, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

shuoweil commented Aug 11, 2026 •

edited

Loading