Skip to content

Re-add core dependency - #3865

Merged
lukesneeringer merged 1 commit into
googleapis:masterfrom
lukesneeringer:pubsub-bump
Aug 24, 2017
Merged

Re-add core dependency#3865
lukesneeringer merged 1 commit into
googleapis:masterfrom
lukesneeringer:pubsub-bump

Conversation

@lukesneeringer

Copy link
Copy Markdown
Contributor

Re-adds the google-cloud-core dependency with the new version.
Fixes #3863.

@lukesneeringer lukesneeringer self-assigned this Aug 24, 2017
@lukesneeringer
lukesneeringer requested a review from dhermes August 24, 2017 20:40
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 24, 2017
@dhermes

dhermes commented Aug 24, 2017

Copy link
Copy Markdown
Contributor

LGTM. Why was core removed to begin with?

@lukesneeringer

Copy link
Copy Markdown
Contributor Author

Because I had no dependencies on it. :-) I did not add google.api.core.Future until very late (yesterday), and did not catch it because tests were still installing it.

@lukesneeringer
lukesneeringer merged commit 4c6801e into googleapis:master Aug 24, 2017
@lukesneeringer
lukesneeringer deleted the pubsub-bump branch August 24, 2017 20:43
parthea pushed a commit that referenced this pull request Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants