Skip to content

chore(storage): Fix flaky test get_object_context#35000

Open
shubhangi-google wants to merge 6 commits into
googleapis:mainfrom
shubhangi-google:fix_flaky_test_object_context
Open

chore(storage): Fix flaky test get_object_context#35000
shubhangi-google wants to merge 6 commits into
googleapis:mainfrom
shubhangi-google:fix_flaky_test_object_context

Conversation

@shubhangi-google

@shubhangi-google shubhangi-google commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

PR Fixes following sample failure:

1) Failure:
Files Snippets::get_object_contexts#test_0001_fetches all object contexts [acceptance/files_test.rb:341]:
In stdout.
--- expected
+++ actual
@@ -1,4 +1,4 @@
 "Custom Contexts for path/file_name_9d512d3ea21775ecf8d953f9f31138f6.txt are:
-Key: my-custom-key, Value: my-custom-value
 Key: my-custom-key-2, Value: my-custom-value-2
+Key: my-custom-key, Value: my-custom-value
 "
 1) Failure:
 Files Snippets::list_object_contexts#test_0001_filters out files on the basis of custom context key [acceptance/files_test.rb:351]:
In stdout.
--- expected
+++ actual
@@ -1,2 +1 @@
-"File: path/file_name_11435b5825845b3fdbe1af94a783ea46.txt has context key: my-custom-key
-"
+""

@shubhangi-google
shubhangi-google force-pushed the fix_flaky_test_object_context branch from b0e1a46 to ebf8067 Compare July 23, 2026 07:12
@shubhangi-google shubhangi-google changed the title Fix flaky test object context chore(storage): Fix flaky test get_object_context Jul 23, 2026
@shubhangi-google
shubhangi-google marked this pull request as ready for review July 23, 2026 07:16
@shubhangi-google
shubhangi-google requested review from a team and yoshi-approver as code owners July 23, 2026 07:16
@shubhangi-google
shubhangi-google marked this pull request as draft July 23, 2026 07:22
@shubhangi-google
shubhangi-google marked this pull request as ready for review July 23, 2026 07:30
@shubhangi-google
shubhangi-google force-pushed the fix_flaky_test_object_context branch from 8e814cb to 66769c0 Compare July 23, 2026 08:03
@shubhangi-google
shubhangi-google marked this pull request as draft July 23, 2026 08:41
@shubhangi-google
shubhangi-google marked this pull request as ready for review July 23, 2026 09:41
@aandreassa

Copy link
Copy Markdown
Contributor

@shubhangi-google I already started working on this. #34844

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants