feat: onboarding google-iam-v1 to Librarian - #36530
Merged
Merged
Conversation
suztomo
marked this pull request as ready for review
September 4, 2026 18:33
suztomo
changed the title
aandreassa
approved these changes
Sep 4, 2026
Contributor
|
feat: is probably fine here. TY! |
suztomo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
google-iam-v1to Librarian.v0.40.1-0.20260904160715-39fbb3f6fecb(incorporating feat(internal/librarian/ruby): support deleting output paths in library declaration librarian#7506). Bumping to this pseudo-version didn't generate any diff fromlibrarian generate --all.Custom File Deletion & Preservation
delete_generation_output_paths: [AUTHENTICATION.md]inlibrarian.yamlto remove unwantedAUTHENTICATION.mdgenerated following code generation (replacing legacyFileUtils.rm_f File.join(OwlBot.staging_dir, "AUTHENTICATION.md")in.owlbot.rb).README.md,google-iam-v1.gemspec, and.yardoptsvia thekeep:list inlibrarian.yaml(replacing legacyOwlBot.prevent_overwrite_of_existing "README.md"andOwlBot.modifierdirectives that removedAUTHENTICATION.mdreferences).Expected Changes during Onboarding
.owlbot.rb,.OwlBot.yaml, and.owlbot-manifest.json.protoc33.2.proto_docs/google/iam/v1/logging/audit_data.rbforgoogle/iam/v1/logging/audit_data.proto.Local Verification
toys ci --test --rubocop --build --yard --doctest --gems google-iam-v1: Passed (9 runs, 182 assertions, 0 failures, 0 errors, 0 RuboCop offenses, gem built successfully, 0 YARD errors).