Skip to content

feat(gax): introduce GrpcRustClient skeleton#5999

Open
joshuatants wants to merge 1 commit into
googleapis:mainfrom
joshuatants:grpc-rust-client-skeleton
Open

feat(gax): introduce GrpcRustClient skeleton#5999
joshuatants wants to merge 1 commit into
googleapis:mainfrom
joshuatants:grpc-rust-client-skeleton

Conversation

@joshuatants

@joshuatants joshuatants commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

For #5991.

Introducing a skeleton unblocks working on the changes needed for Storage for both the hand-written (#6000) and GAPIC (changes to be made to the relevant templates in librarian) clients.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new, conditionally compiled grpc_rust module containing stubs for GrpcRustClient and GrpcRustStreaming under the google_cloud_unstable_grpc_rust configuration. The feedback suggests renaming the getter methods get_polling_error_policy and get_polling_backoff_policy to omit the get_ prefix, aligning with Rust naming conventions and the repository style guide.

Comment thread src/gax-internal/src/grpc/grpc_rust.rs
@codecov

codecov Bot commented Jul 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.73%. Comparing base (affbeb2) to head (3f0287f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5999   +/-   ##
=======================================
  Coverage   97.73%   97.73%           
=======================================
  Files         244      244           
  Lines       61096    61096           
=======================================
  Hits        59710    59710           
  Misses       1386     1386           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joshuatants joshuatants force-pushed the grpc-rust-client-skeleton branch from ab8916c to 3f0287f Compare July 8, 2026 03:56
@joshuatants joshuatants marked this pull request as ready for review July 8, 2026 04:47
@joshuatants joshuatants requested a review from a team as a code owner July 8, 2026 04:47
Comment thread Cargo.toml

[workspace.lints.rust]
unexpected_cfgs = { level = "deny", check-cfg = [
'cfg(google_cloud_unstable_grpc_rust)',

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you want to add this to:

unstable_flags = join(" ", [
"--cfg google_cloud_unstable_trust_boundaries",
"--cfg google_cloud_unstable_storage_bidi",
"--cfg google_cloud_unstable_grpc_server_streaming",
"--cfg google_cloud_unstable_tracing",
])

So the new flag is tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants