feat(gax): introduce GrpcRustClient skeleton#5999
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a new, conditionally compiled grpc_rust module containing stubs for GrpcRustClient and GrpcRustStreaming under the google_cloud_unstable_grpc_rust configuration. The feedback suggests renaming the getter methods get_polling_error_policy and get_polling_backoff_policy to omit the get_ prefix, aligning with Rust naming conventions and the repository style guide.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5999 +/- ##
=======================================
Coverage 97.73% 97.73%
=======================================
Files 244 244
Lines 61096 61096
=======================================
Hits 59710 59710
Misses 1386 1386 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ab8916c to
3f0287f
Compare
|
|
||
| [workspace.lints.rust] | ||
| unexpected_cfgs = { level = "deny", check-cfg = [ | ||
| 'cfg(google_cloud_unstable_grpc_rust)', |
There was a problem hiding this comment.
I think you want to add this to:
google-cloud-rust/.gcb/builds/triggers/main.tf
Lines 37 to 42 in 3774eba
So the new flag is tested.
For #5991.
Introducing a skeleton unblocks working on the changes needed for Storage for both the hand-written (#6000) and GAPIC (changes to be made to the relevant templates in
librarian) clients.