fix: add containsKey override for GenericData class#2151
Merged
diegomarquezp merged 3 commits intogoogleapis:mainfrom Feb 24, 2026
Merged
fix: add containsKey override for GenericData class#2151diegomarquezp merged 3 commits intogoogleapis:mainfrom
diegomarquezp merged 3 commits intogoogleapis:mainfrom
Conversation
diegomarquezp
approved these changes
Feb 20, 2026
lqiu96
reviewed
Feb 20, 2026
google-http-client/src/main/java/com/google/api/client/util/ClassInfo.java
Show resolved
Hide resolved
lqiu96
approved these changes
Feb 20, 2026
|
Can we change the title from |
logachev
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running JFR profiling for Google BigQuery JDBC driver, I saw large amount of samples points to
Map.containsKeyfunction.When I tried local changes to BQ Java SDK to avoid
containsKeycall and callget()instead & validate if result is null or not, calls togetfunction, they don't generate as many samples.Due to
containsKeyoverride missing, it falls back to the defaultMap.containsKeyimplementation which seems to be more expensive in the case ofGenericDataclass. I didn't run sampler with these changes, but attaching results whencontainsKeywas replaced withget()in the SDK.