chore: factor out per operation settings into a separate class#2796
Merged
gcf-merge-on-green[bot] merged 3 commits intomainfrom Feb 23, 2026
Merged
chore: factor out per operation settings into a separate class#2796gcf-merge-on-green[bot] merged 3 commits intomainfrom
gcf-merge-on-green[bot] merged 3 commits intomainfrom
Conversation
product-auto-label
Bot
added
size: xl
Change-Id: I10b658c2a808543ba29830a9ccccb21cdf862768
Change-Id: I92a22daa8ed049b94093eccb054cdb2d401ffdea
igorbernstein2
force-pushed
the
ctx2-per-op
branch
from
74bdb57 to
68b0abc
Compare
product-auto-label
Bot
added
size: l
nimf
approved these changes
Feb 23, 2026
| .setMaxRetryDelay(Duration.ofMinutes(1)) | ||
| .setInitialRpcTimeout(Duration.ofSeconds(5)) | ||
| .setRpcTimeoutMultiplier(1.0) | ||
| .setMaxRpcTimeout(Duration.ofSeconds(20)) |
Contributor
There was a problem hiding this comment.
I know it was like that, but these three settings seem to have a typo somewhere, they don't work well together with the current values:
initial timeout: 5 sec
mutiplier: 1.0
max timeout: 20 sec
Contributor
Author
There was a problem hiding this comment.
I added a todo to keep this pr faithful as a non-functional change
Change-Id: If7064200cbfb1ca7ac1ae0ac41335b88b9b2ed2a
igorbernstein2
added
the
automerge
gcf-merge-on-green
Bot
removed
the
automerge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently Stubs get access to both BigtableClientContext and EnhancedStubSettings. And since BigtableClientContext is derived from EnhancedStubSettings there is quite a bit of overlap settings which makes it hard to keep them consistent. This PR builds towards fixing this by removing access to EnhancedStubSettings and replacing it with disjoint derivative classes.
This PR moves all of the per-op settings into a separate class. The next step will be to copy the remaining bits to BigtableClientContext and have EnhancedBigtableStub depend solely on BigtableClientContext and ClientOperationSettings.