feat: migrate google-cloud-datastore/java into java-datastore #427

kolea2 · 2021-05-17T15:51:28Z

source: https://github.com/googleapis/google-cloud-datastore/tree/master/java/datastore

------------------ - GQL support. - Metadata query support. - Command line tool improvements. - Microsoft Windows support (`gcd.cmd`). - Testing mode. - More intuitive `update_indexes` command (renamed to `updateindexes`). - New `create` command and simplified `start` command. - Improved integration with existing App Engine applications. - Ruby samples. - Java helper for query splitting.

------------------ - API changes: - `BlindWrite` method merged into `Commit`. - Added `list_value` to `Value` and changed `value` to a non-repeated field in `Property`. - In JSON API, string constants are now uppercase and underscore-separated instead of camel-cased (e.g. `LESS_THAN_OR_EQUAL` instead of `lessThanOrEqual`). - GQL changes: - New synthetic literals: `BLOB`, `BLOBKEY`, `DATETIME`, `KEY`. - Support for `IS NULL`. - Fixed partition ID handling for binding arguments. - Documentation changes: - All documentation has been updated to the v1beta2 API. - Getting started guide for Node.js now uses v0.4.5 of google-api-nodejs-client. - Fixed partition ID handling for query requests that include an explicit partition ID. - Fixed scopes in discovery document. - googleapis/google-cloud-datastore#9 - Fixed an issue where command line tool didn't work for some locales. - googleapis/google-cloud-datastore#12

java: add http initializer proto: better comments

In the class comment, the example code was invoking the wrong methods: datastore.stopDatastore() is named datastore.stop() datastore.clearDatastore() is named datastore.clear()

Change-Id: I045ae46d2ac2c4a8685ed8538137a8dbdf94028d

… now that the feature has been released. Bump proto library version to 1.5. Bump proto client version to 1.5. Bump google-http-client version to 1.23. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=171906809

This will allow connection reuse on errors where there was an actual response but the HTTP response code was not 200. This applies to cases where ESF returned an error or forwarded one from the backend (e.g. validation errors, contention, etc.). ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=179095258

Note: this uses an AtomicReference to avoid synchronized static methods (and the class-level lock they entail). ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=180584318

google-cla · 2021-05-17T15:52:16Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to determine that you authored the commits in this PR. Maybe you used a different email address in the git commits than was used to sign the CLA? If someone else authored these commits, then please add them to this pull request and have them confirm that they're okay with them being contributed to Google. If there are co-authors, make sure they're formatted properly.

In order to pass this check, please resolve this problem and then comment@googlebot I fixed it... If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-05-17T16:35:31Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to determine that you authored the commits in this PR. Maybe you used a different email address in the git commits than was used to sign the CLA? If someone else authored these commits, then please add them to this pull request and have them confirm that they're okay with them being contributed to Google. If there are co-authors, make sure they're formatted properly.

In order to pass this check, please resolve this problem and then comment@googlebot I fixed it... If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-05-17T16:38:09Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to determine that you authored the commits in this PR. Maybe you used a different email address in the git commits than was used to sign the CLA? If someone else authored these commits, then please add them to this pull request and have them confirm that they're okay with them being contributed to Google. If there are co-authors, make sure they're formatted properly.

In order to pass this check, please resolve this problem and then comment@googlebot I fixed it... If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-05-17T16:42:20Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to determine that you authored the commits in this PR. Maybe you used a different email address in the git commits than was used to sign the CLA? If someone else authored these commits, then please add them to this pull request and have them confirm that they're okay with them being contributed to Google. If there are co-authors, make sure they're formatted properly.

In order to pass this check, please resolve this problem and then comment@googlebot I fixed it... If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

generated-files-bot · 2021-05-17T19:11:57Z

Warning: This pull request is touching the following templated files:

.kokoro/build.sh

google-cla · 2021-05-17T19:12:46Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to determine that you authored the commits in this PR. Maybe you used a different email address in the git commits than was used to sign the CLA? If someone else authored these commits, then please add them to this pull request and have them confirm that they're okay with them being contributed to Google. If there are co-authors, make sure they're formatted properly.

In order to pass this check, please resolve this problem and then comment@googlebot I fixed it... If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-05-17T19:14:40Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to determine that you authored the commits in this PR. Maybe you used a different email address in the git commits than was used to sign the CLA? If someone else authored these commits, then please add them to this pull request and have them confirm that they're okay with them being contributed to Google. If there are co-authors, make sure they're formatted properly.

In order to pass this check, please resolve this problem and then comment@googlebot I fixed it... If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-05-17T19:29:55Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to determine that you authored the commits in this PR. Maybe you used a different email address in the git commits than was used to sign the CLA? If someone else authored these commits, then please add them to this pull request and have them confirm that they're okay with them being contributed to Google. If there are co-authors, make sure they're formatted properly.

In order to pass this check, please resolve this problem and then comment@googlebot I fixed it... If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-05-17T19:35:30Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to determine that you authored the commits in this PR. Maybe you used a different email address in the git commits than was used to sign the CLA? If someone else authored these commits, then please add them to this pull request and have them confirm that they're okay with them being contributed to Google. If there are co-authors, make sure they're formatted properly.

In order to pass this check, please resolve this problem and then comment@googlebot I fixed it... If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-05-17T19:39:37Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to determine that you authored the commits in this PR. Maybe you used a different email address in the git commits than was used to sign the CLA? If someone else authored these commits, then please add them to this pull request and have them confirm that they're okay with them being contributed to Google. If there are co-authors, make sure they're formatted properly.

In order to pass this check, please resolve this problem and then comment@googlebot I fixed it... If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-05-17T19:50:01Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to determine that you authored the commits in this PR. Maybe you used a different email address in the git commits than was used to sign the CLA? If someone else authored these commits, then please add them to this pull request and have them confirm that they're okay with them being contributed to Google. If there are co-authors, make sure they're formatted properly.

In order to pass this check, please resolve this problem and then comment@googlebot I fixed it... If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

kolea2 · 2021-05-18T14:47:20Z

@BenWhitehead I didn't include the parent pom in https://github.com/googleapis/google-cloud-datastore/tree/master/java and instead switched the parent to this repo's pom. Let me know if you have any concerns.

BenWhitehead · 2021-05-18T16:58:33Z

pom.xml

        <artifactId>datastore-v1-proto-client</artifactId>
-        <version>1.6.3</version>
+        <version>1.6.4-SNAPSHOT</version><!-- {x-version-update:datastore-v1-proto-client:current} -->
        <exclusions>


You may be able to remove this exclusion now that the protos are from this build instead of from maven central.

BenWhitehead · 2021-05-18T16:59:50Z

LGTM, changing parent poms should be fine. Most of the dependencies for the datastore-v1 client were bom managed anyway at this point.

One small comment where the pom may be able to be cleaned up, but not a blocker.

chingor13

Ensure to regular merge or rebase merge if you want to keep individual commit histories.

Google Cloud Datastore and others added 30 commits May 14, 2013 12:08

Initial commit

20dc759

python: fix googleapis#23

4c28630

java: add http initializer proto: better comments

v1beta2-rev1-2.1.0

118b49d

changed class usage in comment to match code

49a43b9

In the class comment, the example code was invoking the wrong methods: datastore.stopDatastore() is named datastore.stop() datastore.clearDatastore() is named datastore.clear()

Corrects error message on exceptions

f4f606f

v1beta2-rev1-3.0.0

229dc4c

v1beta2-rev1-3.0.1

3a74434

Fix bug in LocalDevelopmentDatastore

35cdd30

Update to v1beta3.

34bfe3c

Change-Id: I045ae46d2ac2c4a8685ed8538137a8dbdf94028d

Merge remote-tracking branch 'github/master' into v1beta3

4dbc919

Update RemoteRpc to use correct version of proto library.

6b53466

Add a helper for ancestor filters.

17d14c7

Remove log that credentials aren't provided.

a4a4247

Datastore.java closes InputStreams

1bfd8bb

Do all URL validation in DatastoreFactory

54cc831

s/prom-qa/localhost:1234/

a315247

Update to use the v1 API

29249d4

Remove 'datatore' from path and prepare for release (googleapis#135)

aef3e35

Rename Java testing harness

e1c8dc8

Update test harnesses to use the emulator.

8d62ff4

Add a host() option to DatastoreOptions

c77c3cd

Sync from CL 170707635.

6f1ffea

🚑 fix http connection leak on Datastore errors

b48b091

Cache project ID information retrieved from Compute Engine.

09ce8df

Note: this uses an AtomicReference to avoid synchronized static methods (and the class-level lock they entail). ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=180584318

update to jackson2

3f6b85f

fix assorted warnings

058ca50

google-cla bot added the cla: no This human has *not* signed the Contributor License Agreement. label May 17, 2021

close input stream after each run

156e3df

use try with resources

32ee220

use try with resources

756784b

add test config

320dc12

adjust xmx value

a655613

kolea2 force-pushed the repo-migration branch from 04fa499 to a655613 Compare May 17, 2021 19:49

kolea2 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 17, 2021

BenWhitehead approved these changes May 18, 2021

View reviewed changes

BenWhitehead reviewed May 18, 2021

View reviewed changes

chingor13 approved these changes May 18, 2021

View reviewed changes

kolea2 added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels May 18, 2021

kolea2 merged commit b3ea4b1 into googleapis:master May 18, 2021

kolea2 deleted the repo-migration branch May 18, 2021 21:01

meredithslota mentioned this pull request Jun 27, 2022

Migrate google-cloud-java/google-cloud-datastore to use GAPIC low-level libraries #21

Closed

feat: migrate google-cloud-datastore/java into java-datastore #427

feat: migrate google-cloud-datastore/java into java-datastore #427

Uh oh!

Conversation

kolea2 commented May 17, 2021

Uh oh!

google-cla bot commented May 17, 2021

Uh oh!

google-cla bot commented May 17, 2021

Uh oh!

google-cla bot commented May 17, 2021

Uh oh!

google-cla bot commented May 17, 2021

Uh oh!

generated-files-bot bot commented May 17, 2021

Uh oh!

google-cla bot commented May 17, 2021

Uh oh!

google-cla bot commented May 17, 2021

Uh oh!

google-cla bot commented May 17, 2021

Uh oh!

google-cla bot commented May 17, 2021

Uh oh!

google-cla bot commented May 17, 2021

Uh oh!

google-cla bot commented May 17, 2021

Uh oh!

kolea2 commented May 18, 2021

Uh oh!

BenWhitehead May 18, 2021

Choose a reason for hiding this comment

Uh oh!

BenWhitehead commented May 18, 2021

Uh oh!

chingor13 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants