fix: Change AdminClient close exception to be StatusException.#169
Closed
dpcollins-google wants to merge 1 commit intomasterfrom
Closed
fix: Change AdminClient close exception to be StatusException.#169dpcollins-google wants to merge 1 commit intomasterfrom
dpcollins-google wants to merge 1 commit intomasterfrom
Conversation
google-cla
bot
added
the
cla: yes
anguillanneuf
suggested changes
Jul 21, 2020
Contributor
anguillanneuf
left a comment
anguillanneuf
left a comment
There was a problem hiding this comment.
I think you still need to fix clirr test.
product-auto-label
bot
added
the
api: pubsublite
elharo
suggested changes
Oct 21, 2020
| * | ||
| * @throws StatusException on a failure to properly terminate. | ||
| */ | ||
| void close() throws StatusException; |
There was a problem hiding this comment.
This is a breaking change that requires a major version update.
Collaborator
Author
There was a problem hiding this comment.
There are no major versions in a pre-v1 library. This change will not be submitted as it is superceded by #295. This is also only a breaking change for someone who overrides (not uses) AdminClient, which is not an intended workflow. The previous method signature was void close() throws Exception which this is a subset of.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #148