Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: define Beam version as a Maven property in pom #714

Merged
merged 5 commits into from
Jul 28, 2021

Conversation

dpcollins-google
Copy link
Collaborator

No description provided.

@dpcollins-google dpcollins-google requested review from a team as code owners June 16, 2021 18:32
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

  • samples/snapshot/pom.xml
  • samples/snippets/pom.xml

@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the googleapis/java-pubsublite API. label Jun 16, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 16, 2021
Copy link
Contributor

@anguillanneuf anguillanneuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Samples tests failed.

java.lang.NoSuchMethodError: 'org.apache.beam.vendor.grpc.v1p26p0.com.google.protobuf.Descriptors$EnumValueDescriptor org.apache.beam.model.pipeline.v1.RunnerApi$BeamConstants$Constants.getValueDescriptor()'
	at pubsublite.snippets@1.0.23/pubsublite.beam.BeamReadWriteIT.testQuickstart(BeamReadWriteIT.java:147)

samples/snippets/pom.xml Outdated Show resolved Hide resolved
@dpcollins-google dpcollins-google added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 16, 2021
… and dependency plugins which are present in the base configuration
2.30.0 won't work with the I/O not built with that version. Lower versions will work.
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 16, 2021
@dpcollins-google
Copy link
Collaborator Author

Samples tests failed.

java.lang.NoSuchMethodError: 'org.apache.beam.vendor.grpc.v1p26p0.com.google.protobuf.Descriptors$EnumValueDescriptor org.apache.beam.model.pipeline.v1.RunnerApi$BeamConstants$Constants.getValueDescriptor()'
	at pubsublite.snippets@1.0.23/pubsublite.beam.BeamReadWriteIT.testQuickstart(BeamReadWriteIT.java:147)

This seems like it only happens when 2.30 is specified for beam when using the I/O built against 2.29. I'll look into how we can resolve this in the future, although I'd note that you can use the I/O built against 2.29 with as far back as 2.26 by my testing

@anguillanneuf
Copy link
Contributor

This error is preventing other PRs from passing all tests:

Error:  Failures: 
Error:    SubscriptionPartitionProcessorImplTest.subscriberFailureFails:142 expected com.google.api.gax.rpc.ApiException to be thrown, but nothing was thrown

@anguillanneuf anguillanneuf changed the title deps: bump maven version and remove explicit version override for fmt and dependency plugins which are present in the base configuration deps: define Beam version as a Maven property in pom Jul 28, 2021
@anguillanneuf anguillanneuf self-requested a review July 28, 2021 14:35
@anguillanneuf anguillanneuf merged commit 69106fe into master Jul 28, 2021
@anguillanneuf anguillanneuf deleted the bump_complicated_versions branch July 28, 2021 14:35
gcf-merge-on-green bot pushed a commit that referenced this pull request Jul 29, 2021
🤖 I have created a release \*beep\* \*boop\*
---
## [0.18.0](https://www.github.com/googleapis/java-pubsublite/compare/v0.17.0...v0.18.0) (2021-07-29)


### Features

* split versions.txt to independently release the Beam IO ([#766](https://www.github.com/googleapis/java-pubsublite/issues/766)) ([b6e48dc](https://www.github.com/googleapis/java-pubsublite/commit/b6e48dc7f21ad3f8857d42ca2e3ebc549eea35f6))
* Update CloudPubsubChecks to CloudPubsubTransforms ([#730](https://www.github.com/googleapis/java-pubsublite/issues/730)) ([2e10924](https://www.github.com/googleapis/java-pubsublite/commit/2e109244e43ed4beec50ba9cbc5efadddfb53b5c))


### Bug Fixes

* deflake SubscriptionPartitionProcessorImplTest ([#768](https://www.github.com/googleapis/java-pubsublite/issues/768)) ([c34e430](https://www.github.com/googleapis/java-pubsublite/commit/c34e4303cfb8ce9d0b812ad5c1dd306af32a544e))
* remove DlqProvider which should remain in the beam repo and bump beam version ([#772](https://www.github.com/googleapis/java-pubsublite/issues/772)) ([a540c1d](https://www.github.com/googleapis/java-pubsublite/commit/a540c1dd8eb7e7b2e6afd03550433060635a62fc))


### Dependencies

* define Beam version as a Maven property in pom ([#714](https://www.github.com/googleapis/java-pubsublite/issues/714)) ([69106fe](https://www.github.com/googleapis/java-pubsublite/commit/69106fe309040bc24f2af4c70dfddb602963f365))
* update dependency com.google.apis:google-api-services-bigquery to v2-rev20210617-1.32.1 ([#773](https://www.github.com/googleapis/java-pubsublite/issues/773)) ([e904392](https://www.github.com/googleapis/java-pubsublite/commit/e9043922fbf83220aeff301890fc58b33ae925b4))
* Version bump cloud BOM and remove no longer needed dependency management settings ([#777](https://www.github.com/googleapis/java-pubsublite/issues/777)) ([1cd23cb](https://www.github.com/googleapis/java-pubsublite/commit/1cd23cb3295d521453c1658c25468f4bd82962e2))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsublite Issues related to the googleapis/java-pubsublite API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants