deps: define Beam version as a Maven property in pom#714
Merged
anguillanneuf merged 5 commits intomasterfrom Jul 28, 2021
Merged
deps: define Beam version as a Maven property in pom#714anguillanneuf merged 5 commits intomasterfrom
anguillanneuf merged 5 commits intomasterfrom
Conversation
|
Warning: This pull request is touching the following templated files:
|
anguillanneuf
suggested changes
Jun 16, 2021
Contributor
anguillanneuf
left a comment
There was a problem hiding this comment.
Samples tests failed.
java.lang.NoSuchMethodError: 'org.apache.beam.vendor.grpc.v1p26p0.com.google.protobuf.Descriptors$EnumValueDescriptor org.apache.beam.model.pipeline.v1.RunnerApi$BeamConstants$Constants.getValueDescriptor()'
at pubsublite.snippets@1.0.23/pubsublite.beam.BeamReadWriteIT.testQuickstart(BeamReadWriteIT.java:147)
… and dependency plugins which are present in the base configuration
2.30.0 won't work with the I/O not built with that version. Lower versions will work.
b1b8030 to
86c7b17
Compare
Collaborator
Author
This seems like it only happens when 2.30 is specified for beam when using the I/O built against 2.29. I'll look into how we can resolve this in the future, although I'd note that you can use the I/O built against 2.29 with as far back as 2.26 by my testing |
Contributor
|
This error is preventing other PRs from passing all tests: |
anguillanneuf
approved these changes
Jul 28, 2021
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jul 29, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [0.18.0](https://www.github.com/googleapis/java-pubsublite/compare/v0.17.0...v0.18.0) (2021-07-29) ### Features * split versions.txt to independently release the Beam IO ([#766](https://www.github.com/googleapis/java-pubsublite/issues/766)) ([b6e48dc](https://www.github.com/googleapis/java-pubsublite/commit/b6e48dc7f21ad3f8857d42ca2e3ebc549eea35f6)) * Update CloudPubsubChecks to CloudPubsubTransforms ([#730](https://www.github.com/googleapis/java-pubsublite/issues/730)) ([2e10924](https://www.github.com/googleapis/java-pubsublite/commit/2e109244e43ed4beec50ba9cbc5efadddfb53b5c)) ### Bug Fixes * deflake SubscriptionPartitionProcessorImplTest ([#768](https://www.github.com/googleapis/java-pubsublite/issues/768)) ([c34e430](https://www.github.com/googleapis/java-pubsublite/commit/c34e4303cfb8ce9d0b812ad5c1dd306af32a544e)) * remove DlqProvider which should remain in the beam repo and bump beam version ([#772](https://www.github.com/googleapis/java-pubsublite/issues/772)) ([a540c1d](https://www.github.com/googleapis/java-pubsublite/commit/a540c1dd8eb7e7b2e6afd03550433060635a62fc)) ### Dependencies * define Beam version as a Maven property in pom ([#714](https://www.github.com/googleapis/java-pubsublite/issues/714)) ([69106fe](https://www.github.com/googleapis/java-pubsublite/commit/69106fe309040bc24f2af4c70dfddb602963f365)) * update dependency com.google.apis:google-api-services-bigquery to v2-rev20210617-1.32.1 ([#773](https://www.github.com/googleapis/java-pubsublite/issues/773)) ([e904392](https://www.github.com/googleapis/java-pubsublite/commit/e9043922fbf83220aeff301890fc58b33ae925b4)) * Version bump cloud BOM and remove no longer needed dependency management settings ([#777](https://www.github.com/googleapis/java-pubsublite/issues/777)) ([1cd23cb](https://www.github.com/googleapis/java-pubsublite/commit/1cd23cb3295d521453c1658c25468f4bd82962e2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.